Ignore calls to a method named innerText

camchenry · camchenry · commit af415a614178 · 2023-07-13T14:28:46.000Z
diff --git a/lib/rules/no-innerText.js b/lib/rules/no-innerText.js
@@ -12,6 +12,10 @@ module.exports = {
   create(context) {
     return {
       MemberExpression(node) {
+        // If the member expression is part of a call expression like `.innerText()` then it is not the same
+        // as the `Element.innerText` property, and should not trigger a warning
+        if (node.parent.type === 'CallExpression') return
+
         if (node.property && node.property.name === 'innerText') {
           context.report({
             meta: {
diff --git a/tests/no-innerText.js b/tests/no-innerText.js
@@ -11,6 +11,10 @@ ruleTester.run('no-innerText', rule, {
     {
       code: 'document.querySelector("js-flash-text").textContent = "bar"',
     },
+    {
+      // This is unrelated to the `HTMLElement.innerText` property, and should not trigger a warning
+      code: 'var text = element.textContent()',
+    },
   ],
   invalid: [
     {

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,10 @@ ruleTester.run('no-innerText', rule, {`
`11`	`11`	`{`
`12`	`12`	`code: 'document.querySelector("js-flash-text").textContent = "bar"',`
`13`	`13`	`},`
	`14`	`+ {`
	`15`	+ // This is unrelated to the `HTMLElement.innerText` property, and should not trigger a warning
	`16`	`+ code: 'var text = element.textContent()',`
	`17`	`+ },`
`14`	`18`	`],`
`15`	`19`	`invalid: [`
`16`	`20`	`{`