From 213894fbed802c84bf0b8666a861e57ed2aa156b Mon Sep 17 00:00:00 2001 From: Kendall Gassner Date: Fri, 21 Jul 2023 10:55:03 -0700 Subject: [PATCH 1/3] Update a11y-no-visually-hidden-interactive-element.md ### What Clean up documentation `htmlPropName` was moved to the eslint settings. --- docs/rules/a11y-no-visually-hidden-interactive-element.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/docs/rules/a11y-no-visually-hidden-interactive-element.md b/docs/rules/a11y-no-visually-hidden-interactive-element.md index 24af1e8b..52fdbc12 100644 --- a/docs/rules/a11y-no-visually-hidden-interactive-element.md +++ b/docs/rules/a11y-no-visually-hidden-interactive-element.md @@ -12,7 +12,7 @@ Note: we are not guarding against visually hidden `input` elements at this time. ### Why do we visually hide content? -Visually hiding content can be useful when you want to provide information specifically to screen reader users or other assitive technology users while keeping content hidden from sighted users. +Visually hiding content can be useful when you want to provide information specifically to screen reader users or other assistive technology users while keeping content hidden from sighted users. Applying the following css will visually hide content while still making it accessible to screen reader users. @@ -61,7 +61,6 @@ width: 1px; - className - A css className that visually hides content. Defaults to `sr-only`. - componentName - A react component name that visually hides content. Defaults to `VisuallyHidden`. -- htmlPropName - A prop name used to replace the semantic element that is rendered. Defaults to `as`. ```json { @@ -69,8 +68,7 @@ width: 1px; "error", { "className": "visually-hidden", - "componentName": "VisuallyHidden", - "htmlPropName": "as" + "componentName": "VisuallyHidden" } ] } From cce449a000eb91bc410f0b5c3d44a3685cb74728 Mon Sep 17 00:00:00 2001 From: Kendall Gassner Date: Fri, 21 Jul 2023 18:09:23 +0000 Subject: [PATCH 2/3] clean up; --- lib/rules/a11y-no-visually-hidden-interactive-element.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/rules/a11y-no-visually-hidden-interactive-element.js b/lib/rules/a11y-no-visually-hidden-interactive-element.js index ac3e7142..62336094 100644 --- a/lib/rules/a11y-no-visually-hidden-interactive-element.js +++ b/lib/rules/a11y-no-visually-hidden-interactive-element.js @@ -7,8 +7,7 @@ const defaultcomponentName = 'VisuallyHidden' const schema = generateObjSchema({ className: {type: 'string'}, - componentName: {type: 'string'}, - htmlPropName: {type: 'string'}, + componentName: {type: 'string'} }) /** Note: we are not including input elements at this time From 6e469d26c691bf7f445abd487a4ff8900201d5c3 Mon Sep 17 00:00:00 2001 From: Kendall Gassner Date: Fri, 21 Jul 2023 18:11:09 +0000 Subject: [PATCH 3/3] prettier; --- lib/rules/a11y-no-visually-hidden-interactive-element.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rules/a11y-no-visually-hidden-interactive-element.js b/lib/rules/a11y-no-visually-hidden-interactive-element.js index 62336094..70f7c3cd 100644 --- a/lib/rules/a11y-no-visually-hidden-interactive-element.js +++ b/lib/rules/a11y-no-visually-hidden-interactive-element.js @@ -7,7 +7,7 @@ const defaultcomponentName = 'VisuallyHidden' const schema = generateObjSchema({ className: {type: 'string'}, - componentName: {type: 'string'} + componentName: {type: 'string'}, }) /** Note: we are not including input elements at this time