-
Notifications
You must be signed in to change notification settings - Fork 71
Expand file tree
/
Copy pathadd.go
More file actions
352 lines (309 loc) · 9.97 KB
/
Copy pathadd.go
File metadata and controls
352 lines (309 loc) · 9.97 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
package cmd
import (
"fmt"
"github.com/cli/go-gh/v2/pkg/prompter"
"github.com/github/gh-stack/internal/branch"
"github.com/github/gh-stack/internal/config"
"github.com/github/gh-stack/internal/git"
"github.com/github/gh-stack/internal/modify"
"github.com/github/gh-stack/internal/stack"
"github.com/spf13/cobra"
)
type addOptions struct {
stageAll bool
stageTracked bool
message string
}
func AddCmd(cfg *config.Config) *cobra.Command {
opts := &addOptions{}
cmd := &cobra.Command{
Use: "add [branch]",
Short: "Add a new branch on top of the current stack",
Long: `Add a new branch on top of the current stack.
When -m is omitted but -A or -u is used, your editor opens for the
commit message. When -m is provided without an explicit branch name,
the branch name is auto-generated from the commit message.`,
Example: ` # Add a new named branch to the stack
$ gh stack add my-feature
# Add a branch and commit staged changes
$ gh stack add -Am "Add user authentication" my-feature
# Auto-generate branch name from the commit message
$ gh stack add -m "Fix login bug"
# Add a branch and open editor to write commit message
$ gh stack add -A my-feature`,
Args: cobra.MaximumNArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
return runAdd(cfg, opts, args)
},
}
cmd.Flags().BoolVarP(&opts.stageAll, "all", "A", false, "Stage all changes including untracked files")
cmd.Flags().BoolVarP(&opts.stageTracked, "update", "u", false, "Stage changes to tracked files only")
cmd.Flags().StringVarP(&opts.message, "message", "m", "", "Create a commit with this message")
return cmd
}
func runAdd(cfg *config.Config, opts *addOptions, args []string) error {
// Validate flag combinations
if opts.stageAll && opts.stageTracked {
cfg.Errorf("flags -A and -u are mutually exclusive")
return ErrInvalidArgs
}
result, err := loadStackOptional(cfg, "")
if err != nil {
return ErrNotInStack
}
gitDir := result.GitDir
if err := modify.CheckStateGuard(gitDir); err != nil {
cfg.Errorf("%s", err)
return ErrModifyRecovery
}
if result.Stack == nil {
branchName, err := addBranchNameFromArgs(cfg, opts, args)
if err != nil {
return err
}
return initializeStackFromAdd(cfg, opts, branchName, result.CurrentBranch)
}
sf := result.StackFile
s := result.Stack
currentBranch := result.CurrentBranch
if s.IsFullyMerged() {
cfg.Warningf("All branches in this stack have been merged")
cfg.Printf("Consider creating a new stack with `%s`", cfg.ColorCyan("gh stack init"))
return nil
}
idx := s.IndexOf(currentBranch)
// idx < 0 means we're on the trunk — that's allowed (we'll create
// a new branch from it). Only block if we're in the middle of the stack.
if idx >= 0 && idx < len(s.Branches)-1 {
cfg.Errorf("can only add branches to the top of the stack; run `%s` then `%s`", cfg.ColorCyan("gh stack top"), cfg.ColorCyan("gh stack add"))
cfg.Printf("Or to restructure your stack and insert a branch, use `%s`", cfg.ColorCyan("gh stack modify"))
return ErrInvalidArgs
}
// Check if the current branch is a stack branch with no unique commits
// relative to its parent. If so, the commit should land on this branch
// without creating a new one (e.g., right after init).
wantsCommit := opts.message != "" || opts.stageAll || opts.stageTracked
var branchIsEmpty bool
if wantsCommit && idx >= 0 {
parentBranch := s.ActiveBaseBranch(currentBranch)
shas, err := git.RevParseMulti([]string{parentBranch, currentBranch})
if err == nil {
branchIsEmpty = shas[0] == shas[1]
}
}
// Empty branch path: stage and commit here, don't create a new branch.
if branchIsEmpty {
if err := stageAndValidate(cfg, opts); err != nil {
return ErrSilent
}
sha, err := doCommit(opts.message)
if err != nil {
cfg.Errorf("failed to commit: %s", err)
return ErrSilent
}
cfg.Successf("Created commit %s on %s", cfg.ColorBold(sha), currentBranch)
cfg.Warningf("Branch %s has no prior commits — adding your commit here instead of creating a new branch", currentBranch)
cfg.Printf("When you're ready for the next layer, run `%s` again", cfg.ColorCyan("gh stack add"))
return nil
}
// Resolve branch name:
// explicit name -> used verbatim
// -m without a name -> auto-generated from the commit message
// neither -> prompt for a name
branchName, err := addBranchNameFromArgs(cfg, opts, args)
if err != nil {
return err
}
if branchName == "" {
// No -m and no explicit name — prompt for one.
for {
input, err := promptInput(cfg, "Enter a name for the new branch:")
if err != nil {
if isInterruptError(err) {
printInterrupt(cfg)
return ErrSilent
}
return fmt.Errorf("could not read branch name: %w", err)
}
if input == "" {
cfg.Warningf("branch name cannot be empty, please try again")
continue
}
branchName = input
break
}
}
if branchName == "" {
cfg.Errorf("branch name cannot be empty")
return ErrInvalidArgs
}
if err := sf.ValidateNoDuplicateBranch(branchName); err != nil {
cfg.Errorf("branch %q already exists in the stack", branchName)
return ErrInvalidArgs
}
// If the branch already exists in git but is not part of any stack,
// adopt it instead of erroring. This mirrors the init command's behavior.
adopted := git.BranchExists(branchName)
var adoptedBase string
if adopted {
adoptedBase, err = git.MergeBase(currentBranch, branchName)
if err != nil {
cfg.Errorf("failed to determine the common base of %s and %s: %s", currentBranch, branchName, err)
return ErrSilent
}
}
// Stage changes before creating the branch so we can fail early if
// there's nothing to commit (avoids leaving an empty orphan branch).
if wantsCommit {
if err := stageAndValidate(cfg, opts); err != nil {
return ErrSilent
}
}
if !adopted {
// Create the new branch from the current HEAD and check it out
if err := git.CreateBranch(branchName, currentBranch); err != nil {
cfg.Errorf("failed to create branch: %s", err)
return ErrSilent
}
}
if err := git.CheckoutBranch(branchName); err != nil {
cfg.Errorf("failed to checkout branch: %s", err)
return ErrSilent
}
base := adoptedBase
if !adopted {
base, err = git.RevParse(currentBranch)
if err != nil {
cfg.Warningf("could not resolve base SHA for %s: %s", currentBranch, err)
}
}
s.Branches = append(s.Branches, stack.BranchRef{Branch: branchName, Base: base})
// Commit on the NEW branch (staging already done above)
var commitSHA string
if wantsCommit {
sha, err := doCommit(opts.message)
if err != nil {
cfg.Errorf("failed to commit: %s", err)
return ErrSilent
}
commitSHA = sha
}
if err := stack.Save(gitDir, sf); err != nil {
return handleSaveError(cfg, err)
}
// Print summary
position := len(s.Branches)
if adopted {
if commitSHA != "" {
cfg.Successf("Adopted branch %s (layer %d) with commit %s", cfg.ColorBold(branchName), position, commitSHA)
} else {
cfg.Successf("Adopted existing branch %q into the stack", branchName)
}
} else {
if commitSHA != "" {
cfg.Successf("Created branch %s (layer %d) with commit %s", cfg.ColorBold(branchName), position, commitSHA)
} else {
cfg.Successf("Created and checked out branch %q", branchName)
}
}
return nil
}
func addBranchNameFromArgs(cfg *config.Config, opts *addOptions, args []string) (string, error) {
if len(args) > 0 && args[0] != "" {
return args[0], nil
}
if opts.message == "" {
return "", nil
}
branchName := branch.DateSlug(opts.message)
if branchName == "" {
cfg.Errorf("could not generate branch name")
return "", ErrSilent
}
return branchName, nil
}
func initializeStackFromAdd(cfg *config.Config, opts *addOptions, branchName, currentBranch string) error {
if !cfg.IsInteractive() {
reportBranchNotInStack(cfg, currentBranch, false)
return ErrNotInStack
}
prompt := "Would you like to initialize a new stack?"
var confirmed bool
var err error
if cfg.ConfirmFn != nil {
confirmed, err = cfg.ConfirmFn(prompt, true)
} else {
p := prompter.New(cfg.In, cfg.Out, cfg.Err)
confirmed, err = p.Confirm(prompt, true)
}
if err != nil {
if isInterruptError(err) {
printInterrupt(cfg)
return ErrSilent
}
cfg.Errorf("failed to read confirmation: %s", err)
return ErrSilent
}
if !confirmed {
reportBranchNotInStack(cfg, currentBranch, false)
return ErrNotInStack
}
wantsCommit := opts.message != "" || opts.stageAll || opts.stageTracked
if wantsCommit {
if err := stageAndValidate(cfg, opts); err != nil {
return ErrSilent
}
}
initOpts := &initOptions{}
if branchName != "" {
initOpts.branches = []string{branchName}
}
if err := runInit(cfg, initOpts); err != nil {
return err
}
if wantsCommit {
sha, err := doCommit(opts.message)
if err != nil {
cfg.Errorf("failed to commit: %s", err)
return ErrSilent
}
if branchName == "" {
branchName, _ = git.CurrentBranch()
}
cfg.Successf("Created commit %s on %s", cfg.ColorBold(sha), branchName)
}
return nil
}
// stageAndValidate stages files (if -A or -u is set) and verifies there are
// staged changes to commit. Prints a user-facing error and returns non-nil
// if staging fails or there is nothing to commit.
func stageAndValidate(cfg *config.Config, opts *addOptions) error {
if opts.stageAll {
if err := git.StageAll(); err != nil {
cfg.Errorf("failed to stage changes: %s", err)
return err
}
} else if opts.stageTracked {
if err := git.StageTracked(); err != nil {
cfg.Errorf("failed to stage changes: %s", err)
return err
}
}
if !git.HasStagedChanges() {
if opts.stageAll || opts.stageTracked {
cfg.Errorf("no changes to commit after staging")
} else {
cfg.Errorf("nothing to commit; stage changes first or use -A/-u")
}
return fmt.Errorf("nothing to commit")
}
return nil
}
// doCommit commits staged changes. If message is provided, uses it directly.
// If message is empty, launches the user's editor via git commit.
func doCommit(message string) (string, error) {
if message != "" {
return git.Commit(message)
}
return git.CommitInteractive()
}