Inline optional bool function for all notifications

martinajir · martinajir · commit 81f093e7be6c · 2025-04-22T15:37:39.000Z
diff --git a/pkg/github/notifications.go b/pkg/github/notifications.go
@@ -36,9 +36,9 @@ func ListNotifications(getClient GetClientFn, t translations.TranslationHelperFu
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
-			all, err := OptionalBoolParamWithDefault(request, "all", false) // Default to false unless specified
-			if err != nil {
-				return mcp.NewToolResultError(err.Error()), nil
+			all := false
+			if val, err := OptionalParam[bool](request, "all"); err == nil {
+				all = val
 			}
 
 			opts := &github.NotificationListOptions{
diff --git a/pkg/github/server.go b/pkg/github/server.go
@@ -130,20 +130,6 @@ func OptionalIntParam(r mcp.CallToolRequest, p string) (int, error) {
 	return int(v), nil
 }
 
-// OptionalBoolParamWithDefault is a helper function that retrieves a boolean parameter from the request.
-// If the parameter is not present, it returns the provided default value. If the parameter is present,
-// it validates its type and returns the value.
-func OptionalBoolParamWithDefault(request mcp.CallToolRequest, s string, b bool) (bool, error) {
-	v, err := OptionalParam[bool](request, s)
-	if err != nil {
-		return false, err
-	}
-	if !b {
-		return b, nil
-	}
-	return v, nil
-}
-
 // OptionalIntParamWithDefault is a helper function that can be used to fetch a requested parameter from the request
 // similar to optionalIntParam, but it also takes a default value.
 func OptionalIntParamWithDefault(r mcp.CallToolRequest, p string, d int) (int, error) {

Original file line number	Diff line number	Diff line change
`@@ -36,9 +36,9 @@ func ListNotifications(getClient GetClientFn, t translations.TranslationHelperFu`
`36`	`36`	`if err != nil {`
`37`	`37`	`return mcp.NewToolResultError(err.Error()), nil`
`38`	`38`	`}`
`39`		`- all, err := OptionalBoolParamWithDefault(request, "all", false) // Default to false unless specified`
`40`		`- if err != nil {`
`41`		`- return mcp.NewToolResultError(err.Error()), nil`
	`39`	`+ all := false`
	`40`	`+ if val, err := OptionalParam[bool](request, "all"); err == nil {`
	`41`	`+ all = val`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`opts := &github.NotificationListOptions{`