From fc4f7074138ddd6ef11bcf225b632150545e7c73 Mon Sep 17 00:00:00 2001 From: Keith Cirkel Date: Thu, 1 Dec 2022 09:41:08 +0000 Subject: [PATCH] throw errors rather than resolving them --- src/index.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/index.ts b/src/index.ts index 4a69ccf..bad1b3a 100644 --- a/src/index.ts +++ b/src/index.ts @@ -1,6 +1,6 @@ interface CachedData { src: string - data: Promise + data: Promise } const privateData = new WeakMap() @@ -65,7 +65,7 @@ export default class IncludeFragmentElement extends HTMLElement { // We will return string or error for API backwards compatibility. We can consider // returning TrustedHTML in the future. - get data(): Promise { + get data(): Promise { return this.#getStringOrErrorData() } @@ -117,7 +117,7 @@ export default class IncludeFragmentElement extends HTMLElement { }) } - load(): Promise { + load(): Promise { return this.#getStringOrErrorData() } @@ -177,13 +177,13 @@ export default class IncludeFragmentElement extends HTMLElement { } } - async #getData(): Promise { + async #getData(): Promise { const src = this.src const cachedData = privateData.get(this) if (cachedData && cachedData.src === src) { return cachedData.data } else { - let data: Promise + let data: Promise if (src) { data = this.#fetchDataWithEvents() } else { @@ -194,10 +194,10 @@ export default class IncludeFragmentElement extends HTMLElement { } } - async #getStringOrErrorData(): Promise { + async #getStringOrErrorData(): Promise { const data = await this.#getData() if (data instanceof Error) { - return data + throw data } return data.toString() }