Enforce Configuration.BuildSignature test coverage

nulltoken · nulltoken · commit 1e79a42d2920 · 2015-08-18T11:01:57.000+02:00
diff --git a/LibGit2Sharp.Tests/CommitFixture.cs b/LibGit2Sharp.Tests/CommitFixture.cs
@@ -538,27 +538,6 @@ public void DirectlyAccessingAnUnknownTreeEntryOfTheCommitReturnsNull()
             }
         }
 
-        [Theory]
-        [InlineData(null, "x@example.com")]
-        [InlineData("", "x@example.com")]
-        [InlineData("X", null)]
-        [InlineData("X", "")]
-        public void CommitWithInvalidSignatureConfigThrows(string name, string email)
-        {
-            string repoPath = InitNewRepository();
-            string configPath = CreateConfigurationWithDummyUser(name, email);
-            var options = new RepositoryOptions { GlobalConfigurationLocation = configPath };
-
-            using (var repo = new Repository(repoPath, options))
-            {
-                Assert.Equal(name, repo.Config.GetValueOrDefault<string>("user.name"));
-                Assert.Equal(email, repo.Config.GetValueOrDefault<string>("user.email"));
-
-                Assert.Throws<LibGit2SharpException>(
-                    () => repo.Commit("Initial egotistic commit", new CommitOptions { AllowEmptyCommit = true }));
-            }
-        }
-
         [Fact]
         public void CanCommitWithSignatureFromConfig()
         {
diff --git a/LibGit2Sharp.Tests/ConfigurationFixture.cs b/LibGit2Sharp.Tests/ConfigurationFixture.cs
@@ -409,5 +409,27 @@ public void PassingANonExistingLocalConfigurationFileToBuildFromthrowss()
             Assert.Throws<FileNotFoundException>(() => Configuration.BuildFrom(
                 Path.Combine(Path.GetTempPath(), Path.GetRandomFileName())));
         }
+
+        [Theory]
+        [InlineData(null, "x@example.com")]
+        [InlineData("", "x@example.com")]
+        [InlineData("X", null)]
+        [InlineData("X", "")]
+        public void CannotBuildAProperSignatureFromConfigWhenFullIdentityCannotBeFoundInTheConfig(string name, string email)
+        {
+            string repoPath = InitNewRepository();
+            string configPath = CreateConfigurationWithDummyUser(name, email);
+            var options = new RepositoryOptions { GlobalConfigurationLocation = configPath };
+
+            using (var repo = new Repository(repoPath, options))
+            {
+                Assert.Equal(name, repo.Config.GetValueOrDefault<string>("user.name"));
+                Assert.Equal(email, repo.Config.GetValueOrDefault<string>("user.email"));
+
+                Signature signature = repo.Config.BuildSignature(DateTimeOffset.Now);
+
+                Assert.Null(signature);
+            }
+        }
     }
 }
