Use lowercase letters for IPv6 addresses.

akr · akr · commit 1da3a31a5f02 · 2019-07-30T11:59:54.000+09:00
Reported by chucke (Tiago Cardoso).
Patch by jeremyevans0 (Jeremy Evans).
[Bug #14612]
diff --git a/lib/resolv.rb b/lib/resolv.rb
@@ -2531,7 +2531,7 @@ def initialize(address) # :nodoc:
     attr_reader :address
 
     def to_s # :nodoc:
-      address = sprintf("%X:%X:%X:%X:%X:%X:%X:%X", *@address.unpack("nnnnnnnn"))
+      address = sprintf("%x:%x:%x:%x:%x:%x:%x:%x", *@address.unpack("nnnnnnnn"))
       unless address.sub!(/(^|:)0(:0)+(:|$)/, '::')
         address.sub!(/(^|:)0(:|$)/, '::')
       end
diff --git a/test/resolv/test_dns.rb b/test/resolv/test_dns.rb
@@ -216,6 +216,22 @@ def test_ipv6_create
     assert_instance_of Resolv::IPv6, Resolv::IPv6.create('::1:127.0.0.1'), ref
   end
 
+  def test_ipv6_to_s
+    test_cases = [
+      ["2001::abcd:abcd:abcd", "2001::ABcd:abcd:ABCD"],
+      ["2001:db8::1", "2001:db8::0:1"],
+      ["::", "0:0:0:0:0:0:0:0"],
+      ["2001::", "2001::0"],
+      ["2001:db8::1:1:1:1:1", "2001:db8:0:1:1:1:1:1"],
+      ["1::1:0:0:0:1", "1:0:0:1:0:0:0:1"],
+      ["1::1:0:0:1", "1:0:0:0:1:0:0:1"],
+    ]
+
+    test_cases.each do |expected, ipv6|
+      assert_equal expected, Resolv::IPv6.create(ipv6).to_s
+    end
+  end
+
   def test_ipv6_should_be_16
     ref = '[rubygems:1626]'
 
