Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Security: Make optional the hard-coded Security Group runner_sg? #748

@boldandbusted

Description

@boldandbusted

Howdy. I have a restriction in an environment that prevents wide open egress AWS Security Group rules from being applied (automation actually reverses what this module sets). Each time I apply this rule the automation undoes this, so we get repeating change-in-place loops from TF apply to apply. I'd rather manage this via other means - like using the default SG for the VPC. Is this possible? Or am I missing a path to this functionality that already is available via the module input variables?

https://github.com/philips-labs/terraform-aws-github-runner/blob/65aab803262e0616a8895d2fdbc0bc112e2572f9/modules/runners/main.tf#L117

What would be great would be a method to either:

  • Customize this SG
  • Disable applying this SG (and then rely on the VPC default SG)

Note that I'm already using runner_additional_security_group_ids input variable to specify the default VPC SG, but I don't think I can use that to undo what this code is doing?

Thanks in advance! :) Happy to provide more info.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions