From 7328564d1875df5998d0ef03730e0e0134b81370 Mon Sep 17 00:00:00 2001
From: Mario Tacke <tacke.mario@gmail.com>
Date: Sat, 16 Jun 2018 15:42:16 -0700
Subject: [PATCH] Replace commit author name with login

GitHub markdown converts @-references with links to user profiles. Using
the full author name means potentially including a space which breaks this
linking behavior. Instead of the author name (Ex: Mario Tacke), this fix
uses the author login (Ex: mariotacke) to form a proper link in the
release notes and changelog).

This fixes #158
---
 lib/src/Gren.js   |  4 ++--
 test/Gren.spec.js | 26 +++++++++++++-------------
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/lib/src/Gren.js b/lib/src/Gren.js
index a7156463..1f19056a 100644
--- a/lib/src/Gren.js
+++ b/lib/src/Gren.js
@@ -465,12 +465,12 @@ class Gren {
      * @return {string}
      */
     // eslint-disable-next-line camelcase
-    _templateCommits({ sha, html_url, commit: { author: { name }, message } }) {
+    _templateCommits({ sha, html_url, commit: { author: { login }, message } }) {
         return generate({
             sha,
             message: message.split('\n')[0],
             url: html_url,
-            author: name
+            author: login
         }, this.options.template.commit);
     }
 
diff --git a/test/Gren.spec.js b/test/Gren.spec.js
index be425661..96064f70 100644
--- a/test/Gren.spec.js
+++ b/test/Gren.spec.js
@@ -345,7 +345,7 @@ describe('Gren', () => {
                     commit: {
                         message: 'First commit',
                         author: {
-                            name: 'alexcanessa'
+                            login: 'alexcanessa'
                         }
                     }
                 },
@@ -353,7 +353,7 @@ describe('Gren', () => {
                     commit: {
                         message: 'This is another commit',
                         author: {
-                            name: 'alexcanessa'
+                            login: 'alexcanessa'
                         }
                     }
                 },
@@ -361,7 +361,7 @@ describe('Gren', () => {
                     commit: {
                         message: 'Merge branch into master: Something else here to be tested',
                         author: {
-                            name: 'alexcanessa'
+                            login: 'alexcanessa'
                         }
                     }
                 },
@@ -369,7 +369,7 @@ describe('Gren', () => {
                     commit: {
                         message: 'This is the last one',
                         author: {
-                            name: 'alexcanessa'
+                            login: 'alexcanessa'
                         }
                     }
                 }
@@ -387,12 +387,12 @@ describe('Gren', () => {
         it('Should not return the last message', () => {
             const lastMessage = commitMessages.slice(-1)[0];
 
-            assert.notInclude(gren._generateCommitsBody(commitMessages), `${lastMessage.commit.message} - ${lastMessage.commit.author.name}`, 'Generate the messages');
+            assert.notInclude(gren._generateCommitsBody(commitMessages), `${lastMessage.commit.message} - ${lastMessage.commit.author.login}`, 'Generate the messages');
             assert.deepEqual(gren._generateCommitsBody([{
                 commit: {
                     message: 'One message',
                     author: {
-                        name: 'alexcanessa'
+                        login: 'alexcanessa'
                     }
                 }
             }]), 'One message - alexcanessa', 'One message passed');
@@ -400,7 +400,7 @@ describe('Gren', () => {
                 commit: {
                     message: 'One',
                     author: {
-                        name: 'alexcanessa'
+                        login: 'alexcanessa'
                     }
                 }
             },
@@ -408,7 +408,7 @@ describe('Gren', () => {
                 commit: {
                     message: 'Two',
                     author: {
-                        name: 'alexcanessa'
+                        login: 'alexcanessa'
                     }
                 }
             }]), 'One - alexcanessa', 'Two message passed');
@@ -416,7 +416,7 @@ describe('Gren', () => {
                 commit: {
                     message: 'One',
                     author: {
-                        name: 'alexcanessa'
+                        login: 'alexcanessa'
                     }
                 }
             },
@@ -424,7 +424,7 @@ describe('Gren', () => {
                 commit: {
                     message: 'Two',
                     author: {
-                        name: 'alexcanessa'
+                        login: 'alexcanessa'
                     }
                 }
             },
@@ -432,7 +432,7 @@ describe('Gren', () => {
                 commit: {
                     message: 'Three',
                     author: {
-                        name: 'alexcanessa'
+                        login: 'alexcanessa'
                     }
                 }
             }]), 'One - alexcanessa\nTwo - alexcanessa', 'Three message passed');
@@ -441,7 +441,7 @@ describe('Gren', () => {
         it('Should only return the messages defined in the options', () => {
             gren.options.includeMessages = 'commits';
 
-            const messages = msg => `${commitMessages[msg].commit.message} - ${commitMessages[msg].commit.author.name}`;
+            const messages = msg => `${commitMessages[msg].commit.message} - ${commitMessages[msg].commit.author.login}`;
 
             assert.deepEqual(gren._generateCommitsBody(commitMessages), `${messages(0)}\n${messages(1)}`, 'Using commits as includeMessages');
 
@@ -455,7 +455,7 @@ describe('Gren', () => {
         it('Should not return commits with ignored words', () => {
             gren.options.ignoreCommitsWith = ['another'];
 
-            const messages = msg => `${commitMessages[msg].commit.message} - ${commitMessages[msg].commit.author.name}`;
+            const messages = msg => `${commitMessages[msg].commit.message} - ${commitMessages[msg].commit.author.login}`;
 
             assert.notInclude(commitMessages.filter(message => gren._filterCommit(message)), messages(1), 'Ignore another');
         });