fix($compile): make '='-bindings NaN-aware

caitp · caitp · commit 0b0acb03424a · 2014-08-10T03:32:13.000-04:00
Update parent and child scopes correctly when a '='-binding changes from a NaN value. TBR by angular-core Closes angular#8553 Closes angular#8554 Conflicts: test/ng/compileSpec.js
diff --git a/src/ng/compile.js b/src/ng/compile.js
@@ -1474,7 +1474,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
                 if (parentGet.literal) {
                   compare = equals;
                 } else {
-                  compare = function(a,b) { return a === b; };
+                  compare = function(a,b) { return a === b || (a !== a && b !== b); };
                 }
                 parentSet = parentGet.assign || function() {
                   // reset the change, or we will throw this exception on every $digest
diff --git a/test/ng/compileSpec.js b/test/ng/compileSpec.js
@@ -2671,6 +2671,28 @@ describe('$compile', function() {
     });
 
 
+    it('should update parent scope when "="-bound NaN changes', inject(function($compile, $rootScope) {
+      $rootScope.num = NaN;
+      compile('<div my-component reference="num"></div>');
+      var isolateScope = element.isolateScope();
+      expect(isolateScope.reference).toBeNaN();
+
+      isolateScope.$apply(function(scope) { scope.reference = 64; });
+      expect($rootScope.num).toBe(64);
+    }));
+
+
+    it('should update isolate scope when "="-bound NaN changes', inject(function($compile, $rootScope) {
+      $rootScope.num = NaN;
+      compile('<div my-component reference="num"></div>');
+      var isolateScope = element.isolateScope();
+      expect(isolateScope.reference).toBeNaN();
+
+      $rootScope.$apply(function(scope) { scope.num = 64; });
+      expect(isolateScope.reference).toBe(64);
+    }));
+
+
     describe('attribute', function() {
       it('should copy simple attribute', inject(function() {
         compile('<div><span my-component attr="some text">');

Original file line number	Diff line number	Diff line change
`@@ -1474,7 +1474,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {`
`1474`	`1474`	`if (parentGet.literal) {`
`1475`	`1475`	`compare = equals;`
`1476`	`1476`	`} else {`
`1477`		`- compare = function(a,b) { return a === b; };`
	`1477`	`+ compare = function(a,b) { return a === b \|\| (a !== a && b !== b); };`
`1478`	`1478`	`}`
`1479`	`1479`	`parentSet = parentGet.assign \|\| function() {`
`1480`	`1480`	`// reset the change, or we will throw this exception on every $digest`