refactor: remove doReload arg used only for testing

vojtajina · vojtajina · commit 36a547b852a7 · 2014-08-27T20:45:59.000-07:00
We run unit tests in “strict” mode and thus can’t monkey-patch `window.location` nor `window.location.reload`. In order to avoid full page reload, we could pass location as argument, or another level of indirection, something like this:
```js
var ourGlobalFunkyLocation = window.location;
function reloadWithDebugInfo() {
  window.name = 'NG_ENABLE_DEBUG_INFO!' + window.name;
  ourGlobalFunkyLocation.reload();
}

// in the test
ourGlobalFunkyLocation = {
  reload: function() {}
};
reloadWithDebugInfo();
ourGlobalFunkyLocation = window.location;
```

I don’t think any of these make sense, just so that we can test setting `window.name`. If the `reloadWithDebugInfo` function was more complicated, I would do it.

I don’t think it’s worthy to confuse production code with extra logic which purpose was only to make testing possible.
diff --git a/src/Angular.js b/src/Angular.js
@@ -1465,9 +1465,9 @@ function bootstrap(element, modules, config) {
  * The page should reload and the debug information should now be available.
  *
  */
-function reloadWithDebugInfo(doReload) {
+function reloadWithDebugInfo() {
   window.name = 'NG_ENABLE_DEBUG_INFO!' + window.name;
-  if ( doReload !== false ) window.location.reload();
+  window.location.reload();
 }
 
 var SNAKE_CASE_REGEXP = /[A-Z]/g;
diff --git a/test/AngularSpec.js b/test/AngularSpec.js
@@ -1099,26 +1099,6 @@ describe('angular', function() {
   });
 
 
-  describe("reloadWithDebugInfo", function() {
-
-    it("should reload the current page with debugInfo turned on", function() {
-
-      element = jqLite('<div>{{1+2}}</div>');
-      angular.bootstrap(element);
-      expect(element.hasClass('ng-scope')).toBe(false);
-      dealoc(element);
-
-      // We pass the false to prevent the page actually reloading
-      angular.reloadWithDebugInfo(false);
-
-      element = jqLite('<div>{{1+2}}</div>');
-      angular.bootstrap(element);
-      expect(element.hasClass('ng-scope')).toBe(true);
-      dealoc(element);
-    });
-  });
-
-
   describe('startingElementHtml', function(){
     it('should show starting element tag only', function(){
       expect(startingTag('<ng-abc x="2A"><div>text</div></ng-abc>')).

Original file line number	Diff line number	Diff line change
`@@ -1465,9 +1465,9 @@ function bootstrap(element, modules, config) {`
`1465`	`1465`	`* The page should reload and the debug information should now be available.`
`1466`	`1466`	`*`
`1467`	`1467`	`*/`
`1468`		`-function reloadWithDebugInfo(doReload) {`
	`1468`	`+function reloadWithDebugInfo() {`
`1469`	`1469`	`window.name = 'NG_ENABLE_DEBUG_INFO!' + window.name;`
`1470`		`- if ( doReload !== false ) window.location.reload();`
	`1470`	`+ window.location.reload();`
`1471`	`1471`	`}`
`1472`	`1472`
`1473`	`1473`	`var SNAKE_CASE_REGEXP = /[A-Z]/g;`