perf(jqLite): don't check isString many times in constructor

IgorMinar · IgorMinar · commit 443b521e22f9 · 2014-08-16T21:01:12.000-07:00
Note: no significant perf gain in Chrome
diff --git a/src/jqLite.js b/src/jqLite.js
@@ -226,17 +226,21 @@ function JQLite(element) {
   if (element instanceof JQLite) {
     return element;
   }
+
+  var argIsString;
+
   if (isString(element)) {
     element = trim(element);
+    argIsString = true;
   }
   if (!(this instanceof JQLite)) {
-    if (isString(element) && element.charAt(0) != '<') {
+    if (argIsString && element.charAt(0) != '<') {
       throw jqLiteMinErr('nosel', 'Looking up elements via selectors is not supported by jqLite! See: http://docs.angularjs.org/api/angular.element');
     }
     return new JQLite(element);
   }
 
-  if (isString(element)) {
+  if (argIsString) {
     jqLiteAddNodes(this, jqLiteParseHTML(element));
   } else {
     jqLiteAddNodes(this, element);

Original file line number	Diff line number	Diff line change
`@@ -226,17 +226,21 @@ function JQLite(element) {`
`226`	`226`	`if (element instanceof JQLite) {`
`227`	`227`	`return element;`
`228`	`228`	`}`
	`229`	`+`
	`230`	`+ var argIsString;`
	`231`	`+`
`229`	`232`	`if (isString(element)) {`
`230`	`233`	`element = trim(element);`
	`234`	`+ argIsString = true;`
`231`	`235`	`}`
`232`	`236`	`if (!(this instanceof JQLite)) {`
`233`		`- if (isString(element) && element.charAt(0) != '<') {`
	`237`	`+ if (argIsString && element.charAt(0) != '<') {`
`234`	`238`	`throw jqLiteMinErr('nosel', 'Looking up elements via selectors is not supported by jqLite! See: http://docs.angularjs.org/api/angular.element');`
`235`	`239`	`}`
`236`	`240`	`return new JQLite(element);`
`237`	`241`	`}`
`238`	`242`
`239`		`- if (isString(element)) {`
	`243`	`+ if (argIsString) {`
`240`	`244`	`jqLiteAddNodes(this, jqLiteParseHTML(element));`
`241`	`245`	`} else {`
`242`	`246`	`jqLiteAddNodes(this, element);`