perf($compile): refactor publicLinkFn to simplify the code and use 'for in' loop

IgorMinar · IgorMinar · commit 645625cf349a · 2014-08-16T22:09:48.000-07:00
diff --git a/src/ng/compile.js b/src/ng/compile.js
@@ -889,13 +889,8 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
           : $compileNodes;
 
         if (transcludeControllers) {
-          var names = Object.keys(transcludeControllers);
-          var i = names.length;
-          var name;
-
-          while (i--) {
-            name = names[i];
-            $linkNode.data('$' + name + 'Controller', transcludeControllers[name]);
+          for (var controllerName in transcludeControllers) {
+            $linkNode.data('$' + controllerName + 'Controller', transcludeControllers[controllerName]);
           }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -889,13 +889,8 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {`
`889`	`889`	`: $compileNodes;`
`890`	`890`
`891`	`891`	`if (transcludeControllers) {`
`892`		`- var names = Object.keys(transcludeControllers);`
`893`		`- var i = names.length;`
`894`		`- var name;`
`895`		`-`
`896`		`- while (i--) {`
`897`		`- name = names[i];`
`898`		`- $linkNode.data('$' + name + 'Controller', transcludeControllers[name]);`
	`892`	`+ for (var controllerName in transcludeControllers) {`
	`893`	`+ $linkNode.data('$' + controllerName + 'Controller', transcludeControllers[controllerName]);`
`899`	`894`	`}`
`900`	`895`	`}`
`901`	`896`