Fixed text highlight alignment when text has nonzero padding.

nicklockwood · nicklockwood · commit 0e5422f36c36 · 2015-07-27T07:11:29.000-08:00
Summary:
Previously the text highlight overlay did not take padding into account in its positioning, so it would be misaligned for padded text. This fixes that.
diff --git a/Libraries/Text/RCTText.m b/Libraries/Text/RCTText.m
@@ -103,6 +103,7 @@ - (void)drawRect:(CGRect)rect
       _highlightLayer.fillColor = [UIColor colorWithWhite:0 alpha:0.25].CGColor;
       [self.layer addSublayer:_highlightLayer];
     }
+    _highlightLayer.position = (CGPoint){_contentInset.left, _contentInset.top};
     _highlightLayer.path = highlightPath.CGPath;
   } else {
     [_highlightLayer removeFromSuperlayer];

Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,7 @@ - (void)drawRect:(CGRect)rect`
`103`	`103`	`_highlightLayer.fillColor = [UIColor colorWithWhite:0 alpha:0.25].CGColor;`
`104`	`104`	`[self.layer addSublayer:_highlightLayer];`
`105`	`105`	`}`
	`106`	`+ _highlightLayer.position = (CGPoint){_contentInset.left, _contentInset.top};`
`106`	`107`	`_highlightLayer.path = highlightPath.CGPath;`
`107`	`108`	`} else {`
`108`	`109`	`[_highlightLayer removeFromSuperlayer];`