Merge pull request gitpython-developers#226 from yarikoptic/bf-tab-log-lines

Byron · Byron · commit d46e3fe9cb0d · 2015-01-05T15:39:29.000+01:00
BF: allow log line to have no msg (Close gitpython-developers#225)
diff --git a/git/refs/log.py b/git/refs/log.py
@@ -80,11 +80,15 @@ def from_line(cls, line):
         """:return: New RefLogEntry instance from the given revlog line.
         :param line: line without trailing newline
         :raise ValueError: If line could not be parsed"""
-        try:
-            info, msg = line.split('\t', 2)
-        except ValueError:
-            raise ValueError("line is missing tab separator")
-        # END handle first plit
+        fields = line.split('\t', 1)
+        if len(fields) == 1:
+            info, msg = fields[0], None
+        elif len(fields) == 2:
+            info, msg = fields
+        else:
+            raise ValueError("Line must have up to two TAB-separated fields."
+                             " Got %s" % repr(line))
+        # END handle first split
         oldhexsha = info[:40]
         newhexsha = info[41:81]
         for hexsha in (oldhexsha, newhexsha):
