Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit d084b68

Browse files
jmukistio-merge-robot
authored andcommitted
remove unused legacy mixer store code (istio#2207)
Automatic merge from submit-queue. remove unused legacy mixer store code **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note none ```
1 parent 64df35f commit d084b68

File tree

9 files changed

+22
-384
lines changed

9 files changed

+22
-384
lines changed

mixer/cmd/mixs/cmd/validator.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ import (
3434
func validatorCmd(info map[string]template.Info, adapters []adapter.InfoFn, printf, fatalf shared.FormatFn) *cobra.Command {
3535
vc := crd.ControllerOptions{}
3636
var kubeconfig string
37-
kinds := runtime.KindMap(config.InventoryMap(adapters), info)
37+
tmplRepo := template.NewRepository(info)
38+
kinds := runtime.KindMap(config.AdapterInfoMap(adapters, tmplRepo.SupportsTemplate), info)
3839
vc.ResourceNames = make([]string, 0, len(kinds))
3940
for name := range kinds {
4041
vc.ResourceNames = append(vc.ResourceNames, pluralize(name))

mixer/pkg/config/BUILD

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -11,40 +11,21 @@ go_library(
1111
visibility = ["//visibility:public"],
1212
deps = [
1313
"//mixer/pkg/adapter:go_default_library",
14-
"//mixer/pkg/attribute:go_default_library",
1514
"//mixer/pkg/config/crd:go_default_library",
16-
"//mixer/pkg/config/descriptor:go_default_library",
17-
"//mixer/pkg/config/proto:go_default_library",
1815
"//mixer/pkg/config/store:go_default_library",
19-
"//mixer/pkg/expr:go_default_library",
20-
"//mixer/pkg/pool:go_default_library",
21-
"//mixer/pkg/status:go_default_library",
22-
"//mixer/pkg/template:go_default_library",
2316
"//pkg/log:go_default_library",
24-
"@com_github_emicklei_go_restful//:go_default_library",
25-
"@com_github_ghodss_yaml//:go_default_library",
26-
"@com_github_gogo_protobuf//jsonpb:go_default_library",
27-
"@com_github_gogo_protobuf//proto:go_default_library",
28-
"@com_github_googleapis_googleapis//:google/rpc",
29-
"@com_github_hashicorp_go_multierror//:go_default_library",
30-
"@io_istio_api//mixer/v1/config/descriptor:descriptor",
3117
],
3218
)
3319

3420
go_test(
3521
name = "go_default_test",
3622
size = "small",
37-
srcs = [
38-
"adapterInfoRegistry_test.go",
39-
],
23+
srcs = ["adapterInfoRegistry_test.go"],
4024
library = ":go_default_library",
4125
deps = [
42-
"//mixer/pkg/il/testing:go_default_library",
26+
"//mixer/pkg/template:go_default_library",
4327
"//mixer/template/sample:go_default_library",
4428
"//mixer/template/sample/report:go_default_library",
4529
"@com_github_gogo_protobuf//types:go_default_library",
46-
"@com_github_golang_protobuf//ptypes/empty:go_default_library",
47-
"@com_github_golang_protobuf//ptypes/wrappers:go_default_library",
48-
"@org_uber_go_zap//zapcore:go_default_library",
4930
],
5031
)

mixer/pkg/config/adapterInfoRegistry.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,3 @@ func doesBuilderSupportsTemplates(info adapter.Info, hndlrBldrValidator handlerB
9595
}
9696
return true, ""
9797
}
98-
99-
// InventoryMap converts adapter inventory to a builder map.
100-
func InventoryMap(inv []adapter.InfoFn) map[string]*adapter.Info {
101-
m := make(map[string]*adapter.Info, len(inv))
102-
for _, ai := range inv {
103-
bi := ai()
104-
m[bi.Name] = &bi
105-
}
106-
return m
107-
}

mixer/pkg/config/store/BUILD

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,9 @@ go_library(
66
name = "go_default_library",
77
srcs = [
88
"convert.go",
9-
"fsstore.go",
109
"fsstore2.go",
1110
"memstore.go",
1211
"queue.go",
13-
"store.go",
1412
"store2.go",
1513
"validator.go",
1614
],
@@ -31,7 +29,6 @@ go_test(
3129
"fsstore2_test.go",
3230
"queue_test.go",
3331
"store2_test.go",
34-
"store_test.go",
3532
"validator_test.go",
3633
],
3734
library = ":go_default_library",

mixer/pkg/config/store/fsstore.go

Lines changed: 0 additions & 156 deletions
This file was deleted.

mixer/pkg/config/store/store.go

Lines changed: 0 additions & 138 deletions
This file was deleted.

0 commit comments

Comments
 (0)