Use NSEnumerator instead of objectAtIndex

dmcdougall · dmcdougall · commit fac00b2eba4c · 2012-09-18T09:54:27.000+01:00
diff --git a/src/_macosx.m b/src/_macosx.m
@@ -5760,11 +5760,12 @@ - (int)index
     if(nwin > 0)
     {
         [NSApp activateIgnoringOtherApps: YES];
-        NSArray *windowsArray = [[NSApp windows] retain];
-        for (int i = 0; i < [windowsArray count]; i++) {
-            [[windowsArray objectAtIndex:i] orderFront:nil];
+        NSArray *windowsArray = [NSApp windows];
+        NSEnumerator *enumerator = [windowsArray objectEnumerator];
+        NSWindow *window;
+        while ((window = [enumerator nextObject])) {
+            [window orderFront:nil];
         }
-        [windowsArray release];
         [NSApp run];
     }
     Py_INCREF(Py_None);

Original file line number	Diff line number	Diff line change
`@@ -5760,11 +5760,12 @@ - (int)index`
`5760`	`5760`	`if(nwin > 0)`
`5761`	`5761`	`{`
`5762`	`5762`	`[NSApp activateIgnoringOtherApps: YES];`
`5763`		`- NSArray *windowsArray = [[NSApp windows] retain];`
`5764`		`- for (int i = 0; i < [windowsArray count]; i++) {`
`5765`		`- [[windowsArray objectAtIndex:i] orderFront:nil];`
	`5763`	`+ NSArray *windowsArray = [NSApp windows];`
	`5764`	`+ NSEnumerator *enumerator = [windowsArray objectEnumerator];`
	`5765`	`+ NSWindow *window;`
	`5766`	`+ while ((window = [enumerator nextObject])) {`
	`5767`	`+ [window orderFront:nil];`
`5766`	`5768`	`}`
`5767`		`- [windowsArray release];`
`5768`	`5769`	`[NSApp run];`
`5769`	`5770`	`}`
`5770`	`5771`	`Py_INCREF(Py_None);`