Update symbolic.py

Yobmod · web-flow · commit 1d324337c799 · 2021-07-31T14:36:32.000+01:00
diff --git a/git/refs/symbolic.py b/git/refs/symbolic.py
@@ -282,6 +282,7 @@ def set_object(self, object: Union[Commit_ish, 'SymbolicReference'],
 
     commit = cast('Commit', property(_get_commit, set_commit, doc="Query or set commits directly"))
     object = property(_get_object, set_object, doc="Return the object our ref currently refers to")  # type: ignore
+    # reference = property(_get_reference, set_reference, doc="Return the object our ref currently refers to")
 
     def _get_reference(self
                        ) -> Union['Head', 'RemoteReference', 'TagReference', 'Reference']:
@@ -363,21 +364,30 @@ def set_reference(self, ref: Union[str, Commit_ish, 'SymbolicReference'], logmsg
 
         return self
 
-    reference: Union['Head', 'RemoteReference', 'TagReference', 'Reference'] = property(  # type: ignore
-        _get_reference, set_reference,
-        doc="Reference Object we point to")
+    reference: Union['Head', 'RemoteReference', 'TagReference', 'Reference']
+    reference = property(_get_reference, set_reference, doc="Reference Object we point to")    # type: ignore
     ref = reference
-    
-    """
-    @ property
-    def reference(self) -> Union['Head', 'RemoteReference', 'TagReference', 'Reference']:
-        return self._get_reference()
-
-    @ reference.setter
-    def reference(self, ref: Union[str, Commit_ish, 'SymbolicReference'], logmsg: Union[str, None] = None
-                  ) -> 'SymbolicReference':
-        return self.set_reference(ref=ref, logmsg=logmsg)
-    
+    # @ property
+    # def reference(self) -> Union['Head', 'RemoteReference', 'TagReference', 'Reference']:
+    #     return self._get_reference()
+
+    # @ reference.setter
+    # def reference(self, ref: Union[str, Commit_ish, 'SymbolicReference'], logmsg: Union[str, None] = None
+    #               ) -> 'SymbolicReference':
+    #     return self.set_reference(ref=ref, logmsg=logmsg)
+
+    def is_valid(self) -> bool:
+        """
+        :return:
+            True if the reference is valid, hence it can be read and points to
+            a valid object or reference."""
+        try:
+            self.object
+        except (OSError, ValueError):
+            return False
+        else:
+            return True
+
     @ property
     def is_detached(self):
         """
@@ -389,7 +399,6 @@ def is_detached(self):
             return False
         except TypeError:
             return True
-    """
 
     def log(self) -> 'RefLog':
         """
