Merge pull request #686 from jeblair/issue-605

Byron · web-flow · commit bfae362363b2 · 2017-11-02T08:13:26.000+01:00
Only gc.collect() under windows
diff --git a/git/repo/base.py b/git/repo/base.py
@@ -209,9 +209,17 @@ def __del__(self):
     def close(self):
         if self.git:
             self.git.clear_cache()
-            gc.collect()
+            # Tempfiles objects on Windows are holding references to
+            # open files until they are collected by the garbage
+            # collector, thus preventing deletion.
+            # TODO: Find these references and ensure they are closed
+            # and deleted synchronously rather than forcing a gc
+            # collection.
+            if is_win:
+                gc.collect()
             gitdb.util.mman.collect()
-            gc.collect()
+            if is_win:
+                gc.collect()
 
     def __eq__(self, rhs):
         if isinstance(rhs, Repo):
