perf(): Remove inside onChange event

Elias Cohenca · Elias Cohenca · commit 6ca68cb358e2 · 2016-01-13T14:15:07.000+02:00
When the callback run while changing the slider takes a certain amount of time (~50 ms or more), the
 inside onChange can stall resulting in many changes lost along the way while it catches up.
Removing seems to have no visible side effects. It might be possible that this is due to
scope.() being called right before callOnChange(), so the model is updated anyway (see in
applyModel)
diff --git a/dist/rzslider.css b/dist/rzslider.css
@@ -1,7 +1,7 @@
 /*! angularjs-slider - v2.4.0 - 
  (c) Rafal Zajac <rzajac@gmail.com>, Valentin Hervieu <valentin@hervieu.me>, Jussi Saarivirta <jusasi@gmail.com>, Angelin Sirbu <angelin.sirbu@gmail.com> - 
  https://github.com/angular-slider/angularjs-slider - 
- 2015-12-30 */
+ 2016-01-13 */
 rzslider {
   position: relative;
   display: inline-block;
diff --git a/dist/rzslider.js b/dist/rzslider.js
@@ -1,7 +1,7 @@
 /*! angularjs-slider - v2.4.0 - 
  (c) Rafal Zajac <rzajac@gmail.com>, Valentin Hervieu <valentin@hervieu.me>, Jussi Saarivirta <jusasi@gmail.com>, Angelin Sirbu <angelin.sirbu@gmail.com> - 
  https://github.com/angular-slider/angularjs-slider - 
- 2015-12-30 */
+ 2016-01-13 */
 /*jslint unparam: true */
 /*global angular: false, console: false, define, module */
 (function(root, factory) {
@@ -812,10 +812,7 @@
        */
       callOnChange: function() {
         if (this.options.onChange) {
-          var self = this;
-          $timeout(function() {
-            self.options.onChange(self.options.id);
-          });
+          this.options.onChange(this.options.id);
         }
       },
 
diff --git a/dist/rzslider.min.css b/dist/rzslider.min.css
diff --git a/dist/rzslider.min.js b/dist/rzslider.min.js
diff --git a/src/rzslider.js b/src/rzslider.js
@@ -816,10 +816,7 @@
        */
       callOnChange: function() {
         if (this.options.onChange) {
-          var self = this;
-          $timeout(function() {
-            self.options.onChange(self.options.id);
-          });
+          this.options.onChange(this.options.id);
         }
       },
 
diff --git a/tests/spec/rz-slider-service-test.js b/tests/spec/rz-slider-service-test.js
@@ -520,7 +520,6 @@ describe('rzslider - ', function() {
         createSlider(sliderConf);
 
         slider.callOnChange();
-        $timeout.flush();
         sliderConf.options.onChange.calledWith('test').should.be.true;
       });
 
