Fix issue BehaviorTree#31 : convertFromString mandatory for TreeNode::getParam, not Blackboard::get

Davide Faconti · Davide Faconti · commit 3c19712d6d87 · 2018-12-07T15:46:35.000+01:00
diff --git a/include/behaviortree_cpp/blackboard/blackboard.h b/include/behaviortree_cpp/blackboard/blackboard.h
@@ -8,10 +8,7 @@
 #include <unordered_map>
 
 #include "behaviortree_cpp/blackboard/safe_any.hpp"
-#include "behaviortree_cpp/optional.hpp"
 
-template <typename T>
-T convertFromString(const std::string& str);
 
 namespace BT
 {
@@ -74,18 +71,27 @@ class Blackboard
             return false;
         }
 
-        if (!std::is_same<std::string, T>::value &&
-            (val->type() == typeid(SafeAny::SimpleString) || val->type() == typeid(std::string)))
+        value = val->cast<T>();
+        return true;
+    }
+
+    template <typename T>
+    bool get(const std::string& key, const SafeAny::Any* value) const
+    {
+        if (!impl_)
         {
-            value = convertFromString<T>(val->cast<std::string>());
+            return false;
         }
-        else
+        const SafeAny::Any* val = impl_->get(key);
+        if (!val)
         {
-            value = val->cast<T>();
+            return false;
         }
+        value = val;
         return true;
     }
 
+
     template <typename T>
     T get(const std::string& key) const
     {
diff --git a/include/behaviortree_cpp/tree_node.h b/include/behaviortree_cpp/tree_node.h
@@ -147,7 +147,20 @@ class TreeNode
             if ( bb_ && bb_pattern)
             {
                 const std::string stripped_key(&str[2], str.size() - 3);
-                bool found = bb_->get(stripped_key, destination);
+                const SafeAny::Any* val;
+                bool found = bb_->get(stripped_key, val);
+                if( found )
+                {
+                    if( std::is_same<T,std::string>::value == false &&
+                        (val->type() == typeid (std::string) ||
+                         val->type() == typeid (SafeAny::SimpleString)))
+                    {
+                        destination = convertFromString<T>(val->cast<std::string>());
+                    }
+                    else{
+                        destination = val->cast<T>();
+                    }
+                }
                 return found;
             }
             else{

Original file line number	Diff line number	Diff line change
`@@ -8,10 +8,7 @@`
`8`	`8`	`#include <unordered_map>`
`9`	`9`
`10`	`10`	`#include "behaviortree_cpp/blackboard/safe_any.hpp"`
`11`		`-#include "behaviortree_cpp/optional.hpp"`
`12`	`11`
`13`		`-template <typename T>`
`14`		`-T convertFromString(const std::string& str);`
`15`	`12`
`16`	`13`	`namespace BT`
`17`	`14`	`{`
`@@ -74,18 +71,27 @@ class Blackboard`
`74`	`71`	`return false;`
`75`	`72`	`}`
`76`	`73`
`77`		`- if (!std::is_same<std::string, T>::value &&`
`78`		`- (val->type() == typeid(SafeAny::SimpleString) \|\| val->type() == typeid(std::string)))`
	`74`	`+ value = val->cast<T>();`
	`75`	`+ return true;`
	`76`	`+ }`
	`77`	`+`
	`78`	`+ template <typename T>`
	`79`	`+ bool get(const std::string& key, const SafeAny::Any* value) const`
	`80`	`+ {`
	`81`	`+ if (!impl_)`
`79`	`82`	`{`
`80`		`- value = convertFromString<T>(val->cast<std::string>());`
	`83`	`+ return false;`
`81`	`84`	`}`
`82`		`- else`
	`85`	`+ const SafeAny::Any* val = impl_->get(key);`
	`86`	`+ if (!val)`
`83`	`87`	`{`
`84`		`- value = val->cast<T>();`
	`88`	`+ return false;`
`85`	`89`	`}`
	`90`	`+ value = val;`
`86`	`91`	`return true;`
`87`	`92`	`}`
`88`	`93`
	`94`	`+`
`89`	`95`	`template <typename T>`
`90`	`96`	`T get(const std::string& key) const`
`91`	`97`	`{`