minor update

Davide Faconti · Davide Faconti · commit fd59513946c3 · 2019-02-13T15:56:23.000+01:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -15,6 +15,7 @@ list(APPEND CMAKE_MODULE_PATH "${CMAKE_CONFIG_PATH}")
 
 option(BUILD_EXAMPLES   "Build tutorials and examples" ON)
 option(BUILD_UNIT_TESTS "Build the unit tests" ON)
+option(BUILD_TOOLS "Build commandline tools" ON)
 
 #############################################################
 # Find packages
@@ -245,9 +246,11 @@ install(EXPORT ${PROJECT_CONFIG}
 
 ######################################################
 # EXAMPLES and TOOLS
+if(BUILD_TOOLS)
+    add_subdirectory(tools)
+endif()
 
 if( BUILD_EXAMPLES )
-    add_subdirectory(tools)
     add_subdirectory(sample_nodes)
     add_subdirectory(examples)
 endif()
diff --git a/include/behaviortree_cpp/basic_types.h b/include/behaviortree_cpp/basic_types.h
@@ -175,6 +175,11 @@ using Result = Optional<void>;
 
 enum class PortDirection{INPUT, OUTPUT, INOUT };
 
+const char* toStr(PortDirection type);
+
+std::ostream& operator<<(std::ostream& os, const BT::PortDirection& type);
+
+
 class PortInfo
 {
 
diff --git a/src/basic_types.cpp b/src/basic_types.cpp
@@ -186,6 +186,12 @@ std::ostream& operator<<(std::ostream& os, const NodeStatus& status)
     return os;
 }
 
+std::ostream& operator<<(std::ostream& os, const PortDirection& type)
+{
+    os << toStr(type);
+    return os;
+}
+
 std::vector<StringView> splitString(const StringView &strToSplit, char delimeter)
 {
     std::vector<StringView> splitted_strings;
@@ -244,5 +250,15 @@ const std::string &PortInfo::description() const
     return  description_;
 }
 
+const char *toStr(PortDirection type)
+{
+    switch(type)
+    {
+    case PortDirection::INPUT:  return "input_port";
+    case PortDirection::OUTPUT: return "output_port";
+    case PortDirection::INOUT:  return "input_port";
+    }
+}
+
 
 }   // end namespace
diff --git a/src/xml_parsing.cpp b/src/xml_parsing.cpp
@@ -629,22 +629,7 @@ std::string writeTreeNodesModelXML(const BehaviorTreeFactory& factory)
             const auto& port_name = port.first;
             const auto& port_info = port.second;
 
-             XMLElement* port_element = nullptr;
-
-            switch( port_info.direction() )
-            {
-                case PortDirection::INPUT:
-                    port_element = doc.NewElement("input_port");
-                break;
-
-                case PortDirection::OUTPUT:
-                    port_element = doc.NewElement("input_port");
-                break;
-
-                case PortDirection::INOUT:
-                    port_element = doc.NewElement("inout_port");
-                break;
-            }
+            XMLElement* port_element = doc.NewElement( toStr( port_info.direction()) );
 
             port_element->SetAttribute("name", port_name.c_str() );
             if( port_info.type() )

Original file line number	Diff line number	Diff line change
`@@ -175,6 +175,11 @@ using Result = Optional<void>;`
`175`	`175`
`176`	`176`	`enum class PortDirection{INPUT, OUTPUT, INOUT };`
`177`	`177`
	`178`	`+const char* toStr(PortDirection type);`
	`179`	`+`
	`180`	`+std::ostream& operator<<(std::ostream& os, const BT::PortDirection& type);`
	`181`	`+`
	`182`	`+`
`178`	`183`	`class PortInfo`
`179`	`184`	`{`
`180`	`185`