Disable some tests under MSVC x86 optimised build variants.

lewissbaker · Lewis Baker · commit d2bb79c256d4 · 2018-01-08T11:17:20.000+10:30
Compiler is generating bad code for these tests under Visual Studio
15 Update 5.
diff --git a/include/cppcoro/config.hpp b/include/cppcoro/config.hpp
@@ -68,4 +68,50 @@
 /////////////////////////////////////////////////////////////////////////////
 // CPU Detection
 
+/// \def CPPCORO_CPU_X86
+/// Defined to 1 if target CPU is of x86 family.
+#if CPPCORO_COMPILER_MSVC
+# if defined(_M_IX86)
+#  define CPPCORO_CPU_X86 1
+# endif
+#elif CPPCORO_COMPILER_GCC || CPPCORO_COMPILER_CLANG
+# if defined(__i386__)
+#  define CPPCORO_CPU_X86 1
+# endif
+#endif
+#if !defined(CPPCORO_CPU_X86)
+# define CPPCORO_CPU_X86 0
+#endif
+
+/// \def CPPCORO_CPU_X64
+/// Defined to 1 if the target CPU is x64 family.
+#if CPPCORO_COMPILER_MSVC
+# if defined(_M_X64)
+#  define CPPCORO_CPU_X64 1
+# endif
+#elif CPPCORO_COMPILER_GCC || CPPCORO_COMPILER_CLANG
+# if defined(__x86_64__)
+#  define CPPCORO_CPU_X64 1
+# endif
+#endif
+#if !defined(CPPCORO_CPU_X64)
+# define CPPCORO_CPU_X64 0
+#endif
+
+/// \def CPPCORO_CPU_32BIT
+/// Defined if compiling for a 32-bit CPU architecture.
+#if CPPCORO_CPU_X86
+# define CPPCORO_CPU_32BIT 1
+#else
+# define CPPCORO_CPU_32BIT 0
+#endif
+
+/// \def CPPCORO_CPU_64BIT
+/// Defined if compiling for a 64-bit CPU architecture.
+#if CPPCORO_CPU_X64
+# define CPPCORO_CPU_64BIT 1
+#else
+# define CPPCORO_CPU_64BIT 0
+#endif
+
 #endif
diff --git a/test/ip_endpoint_tests.cpp b/test/ip_endpoint_tests.cpp
@@ -3,6 +3,7 @@
 // Licenced under MIT license. See LICENSE.txt for details.
 ///////////////////////////////////////////////////////////////////////////////
 
+#include <cppcoro/config.hpp>
 #include <cppcoro/net/ip_endpoint.hpp>
 
 #include "doctest/doctest.h"
@@ -11,7 +12,20 @@ TEST_SUITE_BEGIN("ip_endpoint");
 
 using namespace cppcoro::net;
 
-TEST_CASE("to_string")
+namespace
+{
+	constexpr bool isMsvc15_5X86Optimised =
+#if CPPCORO_COMPILER_MSVC && CPPCORO_CPU_X86 && _MSC_VER == 1912 && defined(CPPCORO_RELEASE_OPTIMISED)
+		true;
+#else
+		false;
+#endif
+}
+
+// BUG: Skip this test under MSVC 15.5 x86 optimised builds due to a compiler bug
+// that generates bad code.
+// See https://developercommunity.visualstudio.com/content/problem/177151/bad-code-generation-under-x86-optimised-for-stdopt.html
+TEST_CASE("to_string" * doctest::skip{ isMsvc15_5X86Optimised })
 {
 	ip_endpoint a = ipv4_endpoint{ ipv4_address{ 192, 168, 2, 254 }, 80 };
 	ip_endpoint b = ipv6_endpoint{
@@ -22,7 +36,7 @@ TEST_CASE("to_string")
 	CHECK(b.to_string() == "[2001:db8:85a3::8a2e:370:7334]:22");
 }
 
-TEST_CASE("from_string")
+TEST_CASE("from_string" * doctest::skip{ isMsvc15_5X86Optimised })
 {
 	CHECK(ip_endpoint::from_string("") == std::nullopt);
 	CHECK(ip_endpoint::from_string("[foo]:123") == std::nullopt);
diff --git a/test/ipv6_endpoint_tests.cpp b/test/ipv6_endpoint_tests.cpp
@@ -3,6 +3,7 @@
 // Licenced under MIT license. See LICENSE.txt for details.
 ///////////////////////////////////////////////////////////////////////////////
 
+#include <cppcoro/config.hpp>
 #include <cppcoro/net/ipv6_endpoint.hpp>
 
 #include "doctest/doctest.h"
@@ -11,13 +12,25 @@ TEST_SUITE_BEGIN("ipv6_endpoint");
 
 using namespace cppcoro::net;
 
-TEST_CASE("to_string")
+namespace
+{
+	constexpr bool isMsvc15_5X86Optimised =
+#if CPPCORO_COMPILER_MSVC && CPPCORO_CPU_X86 && _MSC_VER == 1912 && defined(CPPCORO_RELEASE_OPTIMISED)
+		true;
+#else
+		false;
+#endif
+}
+
+// BUG: MSVC 15.5 x86 optimised builds generates bad code
+TEST_CASE("to_string" * doctest::skip{ isMsvc15_5X86Optimised })
 {
 	CHECK(ipv6_endpoint{ ipv6_address{ 0x20010db885a30000, 0x00008a2e03707334 }, 80 }.to_string() ==
 		"[2001:db8:85a3::8a2e:370:7334]:80");
 }
 
-TEST_CASE("from_string")
+// BUG: MSVC 15.5 x86 optimised builds generates bad code
+TEST_CASE("from_string" * doctest::skip{ isMsvc15_5X86Optimised })
 {
 	CHECK(ipv6_endpoint::from_string("") == std::nullopt);
 	CHECK(ipv6_endpoint::from_string("  ") == std::nullopt);
