Use COW list for event hooks, to avoid synchronization.

headius · headius · commit 13666ffb58c0 · 2013-10-21T09:53:47.000-05:00
See jruby#1142. This supercedes a fix there. I opted to use CopyOnWriteArrayList here for two reasons: * It does not require synchronization, neither for access nor iter * EventHooks should are only added or removed rarely
diff --git a/core/src/main/java/org/jruby/Ruby.java b/core/src/main/java/org/jruby/Ruby.java
@@ -134,12 +134,7 @@
 import java.security.AccessControlException;
 import java.security.SecureRandom;
 import java.util.*;
-import java.util.concurrent.Callable;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.SynchronousQueue;
-import java.util.concurrent.ThreadPoolExecutor;
-import java.util.concurrent.TimeUnit;
+import java.util.concurrent.*;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicLong;
 import java.util.regex.Pattern;
@@ -4546,7 +4541,7 @@ public CallbackFactory callbackFactory(Class<?> type) {
 
     private final RubySymbol.SymbolTable symbolTable = new RubySymbol.SymbolTable(this);
 
-    private final List<EventHook> eventHooks = new Vector<EventHook>();
+    private final List<EventHook> eventHooks = new CopyOnWriteArrayList<EventHook>();
     private boolean hasEventHooks;  
     private boolean globalAbortOnExceptionEnabled = false;
     private boolean doNotReverseLookupEnabled = false;
