resources: Improve getImageOps error message

jmooring · bep · commit e8577771c327 · 2026-02-26T22:20:08.000+01:00
Closes #14571
diff --git a/resources/resources_integration_test.go b/resources/resources_integration_test.go
@@ -97,7 +97,7 @@ Width: {{ $svg.Width }}
 		}).BuildE()
 
 	b.Assert(err, qt.IsNotNil)
-	b.Assert(err.Error(), qt.Contains, `error calling Width: this method is only available for raster images. To determine if an image is SVG, you can do {{ if eq .MediaType.SubType "svg" }}{{ end }}`)
+	b.Assert(err.Error(), qt.Contains, `error calling Width: resource "/circle.svg" of media type "image/svg+xml" does not support this method: use reflect.IsImageResource, reflect.IsImageResourceProcessable, or reflect.IsImageResourceWithMeta to check if the resource supports this method before calling it`)
 }
 
 // Issue 10255.
diff --git a/resources/transform.go b/resources/transform.go
@@ -395,12 +395,20 @@ func (r resourceAdapter) WithResourceMeta(mp resource.ResourceMetaProvider) reso
 func (r *resourceAdapter) getImageOps() images.ImageResourceOps {
 	img, ok := r.target.(images.ImageResourceOps)
 	if !ok {
-		if r.MediaType().SubType == "svg" {
-			panic("this method is only available for raster images. To determine if an image is SVG, you can do {{ if eq .MediaType.SubType \"svg\" }}{{ end }}")
-		}
-		panic("this method is only available for image resources")
+		instructions := "use reflect.IsImageResource, " +
+			"reflect.IsImageResourceProcessable, or " +
+			"reflect.IsImageResourceWithMeta to check if the resource " +
+			"supports this method before calling it"
+		msg := fmt.Sprintf(
+			"resource %q of media type %q does not support this method: %s",
+			r.Name(),
+			r.MediaType(),
+			instructions,
+		)
+		panic(msg)
 	}
 	r.init(false, false)
+
 	return img
 }
 

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ Width: {{ $svg.Width }}`
`97`	`97`	`}).BuildE()`
`98`	`98`
`99`	`99`	`b.Assert(err, qt.IsNotNil)`
`100`		- b.Assert(err.Error(), qt.Contains, `error calling Width: this method is only available for raster images. To determine if an image is SVG, you can do {{ if eq .MediaType.SubType "svg" }}{{ end }}`)
	`100`	+ b.Assert(err.Error(), qt.Contains, `error calling Width: resource "/circle.svg" of media type "image/svg+xml" does not support this method: use reflect.IsImageResource, reflect.IsImageResourceProcessable, or reflect.IsImageResourceWithMeta to check if the resource supports this method before calling it`)
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`// Issue 10255.`