go/types: make Identical(nil, T) == Identical(T, nil)

adonovan · adonovan · commit 95a895df0c64 · 2016-04-07T14:21:18.000Z
Fixes #15173 Change-Id: I353756f7bc36db0d2b24d40c80771481b7b18f6b Reviewed-on: https://go-review.googlesource.com/21585 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
diff --git a/src/go/types/api_test.go b/src/go/types/api_test.go
@@ -1042,3 +1042,20 @@ func f() {
 		}
 	}
 }
+
+func TestIdentical_issue15173(t *testing.T) {
+	// Identical should allow nil arguments and be symmetric.
+	for _, test := range []struct {
+		x, y Type
+		want bool
+	}{
+		{Typ[Int], Typ[Int], true},
+		{Typ[Int], nil, false},
+		{nil, Typ[Int], false},
+		{nil, nil, true},
+	} {
+		if got := Identical(test.x, test.y); got != test.want {
+			t.Errorf("Identical(%v, %v) = %t", test.x, test.y, got)
+		}
+	}
+}
diff --git a/src/go/types/predicates.go b/src/go/types/predicates.go
@@ -277,6 +277,8 @@ func identical(x, y Type, p *ifacePair) bool {
 			return x.obj == y.obj
 		}
 
+	case nil:
+
 	default:
 		unreachable()
 	}

Original file line number	Diff line number	Diff line change
`@@ -277,6 +277,8 @@ func identical(x, y Type, p *ifacePair) bool {`
`277`	`277`	`return x.obj == y.obj`
`278`	`278`	`}`
`279`	`279`
	`280`	`+ case nil:`
	`281`	`+`
`280`	`282`	`default:`
`281`	`283`	`unreachable()`
`282`	`284`	`}`