[staticcheck,SA5011] false positive with testing common.Errorf(…) #5748
Labels
question
Further information is requested
Comments
|
Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors. |
|
Hello,
package main
import (
"testing"
)
type Foo struct {
Property string
}
func TestPanic(t *testing.T) {
testCases := []struct {
desc string
myObject *Foo
}{
{desc: "example"},
}
for _, tt := range testCases {
t.Run(tt.desc, func(t *testing.T) {
var myObject *Foo
if myObject == nil {
t.Errorf("Commit is nil")
}
if myObject.Property != tt.myObject.Property { // <- Panic
t.Errorf("Property is %s, want %s", myObject.Property, tt.myObject.Property)
}
})
}
}
func TestNotPanic(t *testing.T) {
testCases := []struct {
desc string
myObject *Foo
}{
{desc: "example"},
}
for _, tt := range testCases {
t.Run(tt.desc, func(t *testing.T) {
var myObject *Foo
if myObject == nil {
t.Fatal("Commit is nil") // <- stop the test
}
if myObject.Property != tt.myObject.Property {
t.Errorf("Property is %s, want %s", myObject.Property, tt.myObject.Property)
}
})
}
} |
|
Whoops, sorry for wasting your time, and thank you for the details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Welcome
typechecksection of the FAQ.How did you install golangci-lint?
AUR
Description of the problem
Results in a possible nil pointer dereference finding, event though it cannot be reached.
A return after
t.Errorf(…)solves the false positive.Version of golangci-lint
Configuration
golangci-lint runGo environment
Verbose output of running
A minimal reproducible example or link to a public repository
https://gitlab.com/PlusMinus0/my-release-tools/-/blob/c0bf6b3734b0f146327dbb9a91f15bca6850eaa6/internal/conventional/parse_test.go
Validation
Supporter
The text was updated successfully, but these errors were encountered: