Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Hashing custom version directories takes a very long time then fails #6099

@iwahbe

Description

@iwahbe

Welcome

  • Yes, I'm using a binary release within 2 latest releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've read the typecheck section of the FAQ.
  • Yes, I've tried with the standalone linter if available (e.g., gocritic, go vet, etc.).
  • I agree to follow this project's Code of Conduct

How did you install golangci-lint?

Official binary

Description of the problem

We are seeing build failures from custom plugin builds in our CI when upgrading to v2.5.0:

Error: build process: build golangci-lint binary: custom version: hash plugin directory: read /home/runner/work/pulumi-service/pulumi-service/infrastructure/bin: is a directory

It looks like this error was introduced in #5896. The exact error is non-determanistic, there's multiple things in our repository that don't hash well. node_modules has some invalid symlinks as does a Go vendor folder, and we have a bunch of build artifacts in bin that don't need to be hashed, including a local copy of golangci-lint. This results in a custom build that takes a long time (from trying to hash things that should not be hashed) then fails.

Version of golangci-lint

2.5.0

Configuration

version: "2"
run:
  go: "1.24"
linters:
  default: none
  enable:
    - copyloopvar
    ...
  settings:
    custom:
      tests:
        type: module

Go environment

𝛌 go version
go version go1.25.1 darwin/arm64

Verbose output of running

We didn't get to running before things broke.

A minimal reproducible example or link to a public repository

https://github.com/iwahbe/golangci-lint-custom-version-bug-repro

The example is a bit contrived, but it does reproduce the problem.

Validation

  • Yes, I've included all information above (version, config, etc.).

Supporter

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinglinter: customAbout custom/private linters

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions