Breaking change: Use dev.cel (canonical) protos instead of google.api.expr #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d57a06e to
ff0f3eb
Compare
153518a to
a008695
Compare
6db9be9 to
a2c481e
Compare
03a8a73 to
7ec860d
Compare
….expr Historically C++ was implemented using the unversioned protobuf descriptors. It eventually included a mix of the versioned variant. When moving to OSS, unversioned protobuf descriptors were rewritten to the versioned variant unconditionally. This has created a bit of a conundrum, now that their is an unversioned canonical protobuf descriptor in cel-spec. We have decided to bite the bullet and break the world. The versioned and unversioned protobuf descriptors are wire compatible, so if you run into issues you can serialize and parse to convert between the two. PiperOrigin-RevId: 689865345
7ec860d to
aff8696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: Use dev.cel (canonical) protos instead of google.api.expr
Historically C++ was implemented using the unversioned protobuf descriptors. It eventually included a mix of the versioned variant. When moving to OSS, unversioned protobuf descriptors were rewritten to the versioned variant unconditionally. This has created a bit of a conundrum, now that their is an unversioned canonical protobuf descriptor in cel-spec. We have decided to bite the bullet and break the world. The versioned and unversioned protobuf descriptors are wire compatible, so if you run into issues you can serialize and parse to convert between the two.