Fix misleading error on string -> uint conversion. #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c97c52 to
753117f
Compare
When string -> uint fails it states "doesn't convert to a string" although the request is to convert from a string. Instead choose "cannot convert string to uint", which is the same kind of statement used for other string conversion failures. PiperOrigin-RevId: 696989968
753117f to
8fb742f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix misleading error on string -> uint conversion.
When string -> uint fails it states "doesn't convert to a string" although the
request is to convert from a string. Instead choose "cannot convert string to
uint", which is the same kind of statement used for other string conversion
failures.