Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cel_cc_embed: Open in file in binary mode #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

cel_cc_embed: Open in file in binary mode #1443

merged 1 commit into from
May 2, 2025

Conversation

jchadwick-buf
Copy link
Contributor

@jchadwick-buf jchadwick-buf commented Apr 17, 2025 •
edited
Loading

This is necessary on Windows; otherwise, newline conversion will corrupt the result.

Related issue: #768

jnthntatum
jnthntatum approved these changes May 2, 2025
View reviewed changes
Copy link
Collaborator

@jnthntatum jnthntatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reasonable -- we will still have to apply the change internally and export, but I think we can make copybara a bit better about reporting you as the original author. No action needed on your part right now.

@copybara-service copybara-service bot merged commit 1ce1685 into google:master May 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnthntatum jnthntatum jnthntatum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchadwick-buf @jnthntatum