Add a test matcher for the elements of cel::ListValue and cel::MapValue. #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c724b1 to
9f7a8e9
Compare
Instead of manually unwrapping a list or map to test their contents, they can now be matched with ListValueElements and MapValueElements, e.g.: ASSERT_THAT(l, ListValueIs(ListValueElements(&mgr, ElementsAre(x1, x2, ...))); ASSERT_THAT(l, MapValueIs(MapValueElements(&mgr, UnorderedElementsAre(Pair(k1, v1), ...))); PiperOrigin-RevId: 646514108
9f7a8e9 to
fa439a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test matcher for the elements of cel::ListValue and cel::MapValue.
Instead of manually unwrapping a list or map to test their contents, they can now be matched with ListValueElements and MapValueElements, e.g.:
ASSERT_THAT(l, ListValueIs(ListValueElements(&mgr, ElementsAre(x1, x2, ...)));
ASSERT_THAT(l, MapValueIs(MapValueElements(&mgr, UnorderedElementsAre(Pair(k1, v1), ...)));