moves vector operations to a location where they're operating on complete types #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e28196 to
4bf32e2
Compare
…lete types Several JSON types form members to a vector of an incomplete type, which is not allowed. libc++ has historically turned a blind eye here, but an incoming patch will cause these types to break. This commit intends to get in front of that libc++ change by moving all function definitions that reference vectors to after all JSON objects are defined. PiperOrigin-RevId: 653768903
4bf32e2 to
56d2bae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moves vector operations to a location where they're operating on complete types
Several JSON types form members to a vector of an incomplete type, which is
not allowed. libc++ has historically turned a blind eye here, but an incoming
patch will cause these types to break. This commit intends to get in front of
that libc++ change by moving all function definitions that reference vectors to
after all JSON objects are defined.