Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Swift] Improves the performance creating strings #8772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aardappel merged 1 commit into from
Nov 14, 2025
Merged

[Swift] Improves the performance creating strings #8772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions swift/Sources/FlatBuffers/FlatBufferBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,9 @@ public struct FlatBufferBuilder {
len: size &+ (prefix ? size : 0) &+ FileIdLength,
alignment: _minAlignment)
assert(fileId.count == FileIdLength, "Flatbuffers requires file id to be 4")
_bb.push(string: fileId, len: 4)
fileId.withCString { ptr in
_bb.writeBytes(ptr, len: 4)
}
finish(offset: offset, addPrefix: prefix)
}

Expand Down Expand Up @@ -706,8 +708,9 @@ public struct FlatBufferBuilder {
let len = str.utf8.count
notNested()
preAlign(len: len &+ 1, type: UOffset.self)
_bb.fill(padding: 1)
_bb.push(string: str, len: len)
str.withCString { ptr in
_bb.writeBytes(ptr, len: len &+ 1)
}
push(element: UOffset(len))
return Offset(offset: _bb.size)
}
Expand Down
34 changes: 5 additions & 29 deletions swift/Sources/FlatBuffers/_InternalByteBuffer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,41 +192,17 @@ struct _InternalByteBuffer {
}
}

/// Adds a string to the buffer using swift.utf8 object
/// - Parameter str: String that will be added to the buffer
/// - Parameter len: length of the string
/// Adds a RawPointer into the buffer
/// - Parameter pointer: pointer to be copied into the buffer
/// - Parameter len: length of the data
@inline(__always)
@usableFromInline
mutating func push(string str: String, len: Int) {
mutating func writeBytes(_ ptr: UnsafeRawPointer, len: Int) {
ensureSpace(size: len)
if str.utf8
.withContiguousStorageIfAvailable({ self.push(bytes: $0, len: len) }) !=
nil
{
} else {
let utf8View = str.utf8
for c in utf8View.reversed() {
push(value: c, len: 1)
}
}
}

/// Writes a string to Bytebuffer using UTF8View
/// - Parameters:
/// - bytes: Pointer to the view
/// - len: Size of string
@usableFromInline
@inline(__always)
mutating func push(
bytes: UnsafeBufferPointer<String.UTF8View.Element>,
len: Int) -> Bool
{
memcpy(
_storage.memory.advanced(by: writerIndex &- len),
bytes.baseAddress!,
ptr,
len)
_writerSize = _writerSize &+ len
return true
}

/// Write stores an object into the buffer directly or indirectly.
Expand Down
Loading