Merged
Conversation
Add a check if 'isatty' member exists in the object, required for packaging with PyInstaller.
dbieber
approved these changes
Jan 9, 2024
Collaborator
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running Fire with PyInstaller on Windows by setting the option "console=False" in SPEC file "pyinstaller.spec" (see below) the executable dont work.
PyInstaller SPEC file
Below we have the executable message released:
The Fire code in "formatting_windows.py" invoques an "isatty()" function that does not exists in "sys.stdout" in Python 3.9.
To resolve the release, I check if the "isatty" member exists in the "sys.stdout" object.
IMPORTANT