fix(action): Unset empty gemini_api_key environment variable #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions defaults to passing an empty string for optional inputs that are not explicitly set in a workflow. When the `gemini_api_key` input is unset, it is passed as an empty string to the `GEMINI_API_KEY` environment variable. The Gemini CLI does not handle an empty `GEMINI_API_KEY` variable gracefully, which can lead to unexpected behavior. This commit addresses the issue by explicitly checking if the `GEMINI_API_KEY` variable is empty (`-z`). If it is, the variable is unset before invoking the Gemini CLI. This ensures the CLI's default authentication behavior (e.g., using Application Default Credentials) is triggered correctly when no API key is provided, improving the action's robustness and predictability. Note: This is a temporary workaround to unblock users. The underlying issue of handling empty string inputs will be addressed with improved validation in the Gemini CLI upstream.
HassanJasim
approved these changes
Aug 7, 2025
Merged
google-github-actions-bot
added a commit
that referenced
this pull request
Aug 7, 2025
## What's Changed * fix: typo in `gemini-pr-review.yml` by @JamBalaya56562 in #124 * fix(action): Unset empty gemini_api_key environment variable by @jerop in #127 **Full Changelog**: v0.1.5...v0.1.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions defaults to passing an empty string for optional inputs that are not explicitly set in a workflow. When the
gemini_api_keyinput is unset, it is passed as an empty string to theGEMINI_API_KEYenvironment variable.The Gemini CLI does not handle an empty
GEMINI_API_KEYvariable gracefully, which can lead to unexpected behavior.This commit addresses the issue by explicitly checking if the
GEMINI_API_KEYvariable is empty (-z). If it is, the variable is unset before invoking the Gemini CLI. This ensures the CLI's default authentication behavior (e.g., using Application Default Credentials) is triggered correctly when no API key is provided, improving the action's robustness and predictability.Fixes: #123