bug(debug): use vars (not env) when enabling debug mode
#211
Conversation
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
0e33178 to
e587565
Compare
|
@gemini-cli /review |
1 similar comment
|
@gemini-cli /review |
jerop
left a comment
There was a problem hiding this comment.
Let's add GEMINI_DEBUG as a repository variable in https://github.com/google-github-actions/run-gemini-cli?tab=readme-ov-file#repository-variables
Done |
20ca89d to
64e6eb0
Compare
There was a problem hiding this comment.
📋 Review Summary
The PR correctly switches from using env variables to a dedicated gemini_debug input for enabling debug mode. The changes are consistent across all workflow files and the documentation is updated accordingly. I've made one minor suggestion for improving the shell script in action.yml. Overall, this is a great improvement!
🔍 General Feedback
- The change from
envtovarsis a good practice. - The new
gemini_debuginput is well-defined. - The documentation in
README.mdis clear.
.github/workflows/gemini-cli.yml
Outdated
| settings: |- | ||
| { | ||
| "debug": ${{ fromJSON(env.DEBUG || env.ACTIONS_STEP_DEBUG || false) }}, | ||
| "debug": ${{ fromJSON(vars.GEMINI_DEBUG || vars.DEBUG || vars.ACTIONS_STEP_DEBUG || false) }}, |
There was a problem hiding this comment.
This change is consistent with the changes in action.yml. Good job on updating all the workflow files!
| # Keep track of whether we've failed | ||
| FAILED=false | ||
There was a problem hiding this comment.
low: For clarity and to prevent potential shell scripting errors, it's slightly better to use == for string comparisons within [[...]] and to quote the string literal "true".
| if [[ "${DEBUG}" == "true" ]]; then |
## What's Changed * fix(output): separate the stdout and stderr logs by @sethvargo in #186 * fix: correct step numbering in setup_workload_identity.sh by @jasmeetsb in #188 * Try and address TOCTOU issues in gemini-cli.yml by @sethvargo in #187 * chore: bump `actions/checkout` GitHub Actions by @Marukome0743 in #193 * docs: add gitignore recommendations across all workflows by @jerop in #198 * chore: bump `actions/create-github-app-token` from 2.0.6 to 2.1.1 by @Marukome0743 in #200 * bug(output): do not print output by default by @sethvargo in #202 * Add GOOGLE_API_KEY variable by @vivekkairi in #201 * Stream live output if (and only if) debug mode is enabled by @sethvargo in #207 * bug(debug): use `vars` (not `env`) when enabling debug mode by @sethvargo in #211 * feat: Add GEMINI_MODEL support by @vivekkairi in #214 * feat(actions): use the dispatcher pattern to separate concerns by @sethvargo in #212 * bug(ci): set id-token permissions by @sethvargo in #223 * chore: add a debugger by @sethvargo in #226 * Add release notes generation example in awesome list by @jerop in #225 * feat(invoke): update invoke prompt to better separate execution flow by @sethvargo in #227 * chore(ci): refactor scheduled triage workflow by @sethvargo in #232 * Fix triage workflow by @sethvargo in #233 * Auto trigger PR reviews when they are from branches in repo by @jerop in #234 * rename workflow from `gemini-issue-scheduled-triage` to `gemini-scheduled-triage` by @jerop in #238 * feat: rename triage workflows by @jerop in #240 * feat: rename gemini-cli to gemini-invoke by @jerop in #239 * rename PR review workflow to be consistent with the rest by @jerop in #241 * feat(workflows): refactor examples/workflows to use dispatch pattern by @jerop in #242 * feat: pin example workflows to v0 by @jerop in #246 * add google_api_key input in gemini-triage workflows by @jerop in #243 * feat: add best practices guide by @jerop in #245 ## New Contributors * @vivekkairi made their first contribution in #201 **Full Changelog**: v0.1.11...v0.1.12
No description provided.