add add_campaign_draft.py code example #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wihl
reviewed
Mar 24, 2020
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """This example adds a campaign draft for a campaign. | ||
| Make sure you specify a campaign that has a non-shared budget. |
There was a problem hiding this comment.
nit: leave a blank line between "This..." and "Make..."
| import sys | ||
| from uuid import uuid4 | ||
|
|
||
| import google.ads.google_ads.client |
There was a problem hiding this comment.
Replace by
from google.ads.google_ads.client import GoogleAdsClient
|
|
||
|
|
||
| def main(client, customer_id, base_campaign_id): | ||
| campaign_service = client.get_service('CampaignService',version='v3') |
There was a problem hiding this comment.
nit: space required between 'CampaignService', version='v3'
| print(f'\t\tOn field: {field_path_element.field_name}') | ||
| sys.exit(1) | ||
|
|
||
| print(f'Created campaign draft: ' |
There was a problem hiding this comment.
nit: does not need an f-string since there is no substitution
| sys.exit(1) | ||
|
|
||
| print(f'Created campaign draft: ' | ||
| f'{campaign_draft_response.results[0].resource_name}.') |
There was a problem hiding this comment.
enclose resulting resource name in quotes, ie.
f'"{campaign_draft_response.results[0].resource_name}".')
fiboknacky
approved these changes
Mar 24, 2020
|
Addressed David's comments. PTAL. thx |
wihl
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add add_campaign_draft.py code example