Replace main add_responsive_search_ad example with newer version... #753
Conversation
that shows how to include geo targeting and image extensions.
| """ | ||
| This example shows how to create a complete Responsive Search ad. |
There was a problem hiding this comment.
What do we mean by complete?
| """ | ||
| This example shows how to create a complete Responsive Search ad. | ||
|
|
||
| Includes creation of: budget, campaign, ad group, ad group ad, |
There was a problem hiding this comment.
If this is what we mean by complete, consider changing the previous sentence to be
... to create a Responsive Search Ad with ....
| def main(client, customer_id, ad_group_id): | ||
| ad_group_ad_service = client.get_service("AdGroupAdService") | ||
| # Keywords from user. | ||
| _KEYWORD_TEXT_EXACT_1 = "example of exact match" |
There was a problem hiding this comment.
The use of an initial underbar is very confusing since variable that begin this way are handled in a specific way by the Python import system. Capital letters are sufficient to indicate global variables.
| ad_group.campaign = campaign_resource_name | ||
| ad_group.type_ = client.enums.AdGroupTypeEnum.SEARCH_STANDARD | ||
|
|
||
| # If you want to set up a max CPC bid uncomment line below. |
|
|
||
| image_asset_resource_name = mutate_asset_response.results[0].resource_name | ||
|
|
||
| # Step 6.2 - Create Image Extension |
There was a problem hiding this comment.
Why are we including this example of extensions? As of 3 April 2023 we want people to stop doing this. Some users, if they are early in the migration process will no longer be able to do this.
I recommend not including any code that deals with extensions.
There was a problem hiding this comment.
Recall we discussed offline that these changes are just a renaming existing example that we recently approved (#715).
We'll update this example (along with others) so that it uses assets around when the April 3 migration happens, for now this does illustrate the correct workflow for this type of functionality, right?
|
Closing this PR for now so that we can update the example to use image assets before making it the default example for adding RSAs. |
...that shows how to include geo targeting and image extensions. These changes are simply:
basic_operations/add_responsive_search_ad.pyexample.advanced_operations/add_responsive_search_ad_full.pyexample so that it's now the mainadd_responsive_search_ad.pyexample.