This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: correctly send labels on register calls. #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 65.74% // Head: 65.74% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
=======================================
Coverage 65.74% 65.74%
=======================================
Files 19 19
Lines 1769 1769
Branches 354 354
=======================================
Hits 1163 1163
Misses 520 520
Partials 86 86
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jasonborg
approved these changes
Dec 6, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
🤖 I have created a release *beep* *boop* --- ## [7.2.0](https://togithub.com/googleapis/cloud-debug-nodejs/compare/v7.1.1...v7.2.0) (2022-12-09) ### Features * Add active debuggee support ([#1121](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1121)) ([a421509](https://togithub.com/googleapis/cloud-debug-nodejs/commit/a421509d7c616a4ed48302498886ffa66bfefad9)) * Add error handling to firebase controller. ([#1116](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1116)) ([a188e34](https://togithub.com/googleapis/cloud-debug-nodejs/commit/a188e347131168d21d01f77267863e53ae1043a8)) ### Bug Fixes * Correctly send labels on register calls. ([#1118](https://togithub.com/googleapis/cloud-debug-nodejs/issues/1118)) ([007cbbd](https://togithub.com/googleapis/cloud-debug-nodejs/commit/007cbbd3df765b06978aa5604bcbdb4925cf725e)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debuggee labels were not being sent to the firebase rtdb when registering. This resulted in debuggees without adequate information to identify them using the snapshot debugger cli. There was no functional difference otherwise.