feat: Add a TransportCallMiddleware#640
Merged
Merged
Conversation
bshaffer
reviewed
Dec 2, 2025
Contributor
bshaffer
left a comment
There was a problem hiding this comment.
This looks great!
We should wait on integration in googleapis/google-cloud-php#8764, and a test which fails against main but passes for this branch, to ensure it works as expected.
bshaffer
reviewed
Dec 3, 2025
bshaffer
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added a new feature to the GapicClientTrait adding the new method:
pependMiddleware.Adding a middleware involves passing a closure to the
addMiddlewareandprependMiddlewarewith the first parameter being aMiddlewareInterfacelike so:For
prependMiddlewarethis is not always the case as the final call in thecallStackis not aMiddlewareInterfacebut a closure.This PR moves this closure into its own middleware so the
$callStackvariable is always of typeMiddlewareInterfacefixing the problem with theprependMiddlewareclass and adding more consistency to typing.