This repository was archived by the owner on Jan 23, 2025. It is now read-only.
feat: use cache when listing PRs and issues #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd962b6 to
3034b92
Compare
1130c26 to
588a7ca
Compare
tmatsuo
reviewed
Aug 29, 2022
ruyadorno
reviewed
Aug 29, 2022
| } | ||
| items.push( | ||
| ...localItems.map(item => { | ||
| return {repo, item}; | ||
| }) | ||
| ); | ||
| scanned++; | ||
| orb1.text = `[${scanned}/${repos.length}] Scanning repos for PRs`; | ||
| orb1.text = `[${scanned}/${repos.length}] Scanning repos for ${ | ||
| type === 'issues' ? 'issue' : 'PR' |
There was a problem hiding this comment.
not familiar with type annotations in TypeScript and I'm really curious, is it possible to use String(type) here instead? would simplify these quite a bit
There was a problem hiding this comment.
I mean it's simple enough imo
There was a problem hiding this comment.
Yes, could just use ${type} (type is already a string internally), it's just singular "issue" vs plural "issues" being handled here. I didn't invent anything new here, I just copy-pasted this from another place in the code, there are quite a lot of those.
tmatsuo
approved these changes
Aug 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have 167 repositories matching my filters at this moment. Quite often, I need to do several things one after one, e.g. first tag all matching PRs, then approve. Listing across 167 repositories every time is painful, takes time, and consumes quota.
Let's cache everything for 1 hour. The break glass
--nocacheoption is also provided.