Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: return impersonated token as lastReceivedToken #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2025
Merged

fix: return impersonated token as lastReceivedToken #606

merged 3 commits into from
Feb 5, 2025

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Feb 4, 2025

No description provided.

@bshaffer bshaffer requested a review from a team as a code owner February 4, 2025 17:53
@bshaffer bshaffer mentioned this pull request Feb 4, 2025
Closed
@mruell
Copy link

mruell commented Feb 5, 2025

(related: #605)

Looks good to me, only were thinking about setting lastImpersonatedAccessToken to null first in fetchAuthToken, in case a later call does not have serviceAccountImpersonationUrl.

But I guess this case shouldn't be possible, so this should be fine

Thanks a lot and best!

@bshaffer
Copy link
Contributor Author

bshaffer commented Feb 5, 2025

in case a later call does not have serviceAccountImpersonationUrl.

The null-coalescing (??) operator will return false if the variable hasn't been initialized, so this case is covered!

Thanks for your review

dazuma
dazuma approved these changes Feb 5, 2025
View reviewed changes
Copy link

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bshaffer bshaffer merged commit 33c3c85 into main Feb 5, 2025
13 checks passed
@bshaffer bshaffer deleted the fix-get-last-received-token-for-impersonated-tokens branch February 5, 2025 20:18
This was referenced Feb 5, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@dazuma dazuma dazuma approved these changes

@mruell mruell mruell approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bshaffer @mruell @dazuma