Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't bundle tests in jars #3728

@elharo

Description

@elharo

I downloaded and unzipped google-cloud-dns-0.63.0-alpha-tests.jar. Here's what I found inside it. We're definitely bundling the actual tests into these jars. We either shouldn't do this (just include mocks and the like) or otherwise not put these in the BOM.

$ jar tvf google-cloud-dns-0.63.0-alpha-tests.jar
     0 Thu Sep 20 16:47:10 EDT 2018 META-INF/
   617 Thu Sep 20 16:47:10 EDT 2018 META-INF/MANIFEST.MF
     0 Thu Sep 20 16:47:10 EDT 2018 com/
     0 Thu Sep 20 16:47:10 EDT 2018 com/google/
     0 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/
     0 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/
     0 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/it/
 19805 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsImplTest.class
  4099 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ProjectInfoTest.class
 46519 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/it/ITDnsTest.class
  8991 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/SerializationTest.class
  4908 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/RecordSetTest.class
  3820 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsExceptionTest.class
  7528 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ChangeRequestInfoTest.class
  2639 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest.class
   879 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$5.class
  3088 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsBatchResultTest.class
  5755 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ZoneInfoTest.class
 28870 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsBatchTest.class
   672 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$3.class
   605 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsImplTest$1.class
   672 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$1.class
   879 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$6.class
   672 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$4.class
 15648 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ZoneTest.class
  8405 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/ChangeRequestTest.class
  1207 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsOptionsTest.class
  6212 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/DnsTest.class
   672 Thu Sep 20 16:47:10 EDT 2018 com/google/cloud/dns/OptionTest$2.class
     0 Thu Sep 20 16:47:10 EDT 2018 META-INF/maven/
     0 Thu Sep 20 16:47:10 EDT 2018 META-INF/maven/com.google.cloud/
     0 Thu Sep 20 16:47:10 EDT 2018 META-INF/maven/com.google.cloud/google-cloud-dns/
  2486 Thu Sep 20 13:30:42 EDT 2018 META-INF/maven/com.google.cloud/google-cloud-dns/pom.xml
   131 Thu Sep 20 16:47:10 EDT 2018 META-INF/maven/com.google.cloud/google-cloud-dns/pom.properties
   246 Thu Sep 20 16:47:10 EDT 2018 META-INF/INDEX.LIST

Metadata

Metadata

Assignees

Labels

type: cleanupAn internal cleanup or hygiene concern.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions