Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Google Cloud components should not depend on -android versions #4440

@stevenschlansker

Description

@stevenschlansker

Currently, the google-cloud-logging-logback component depends on Guava version 26.0-andriod. This is not appropriate for Google Cloud projects which are running on a full JDK in e.g. GKE. The two different versions are not considered compatible by Maven and version checker plugins.

It looks like this issue was introduced in #3980

Environment details

  • OS: Fedora Linux 29
  • Java version: JDK 11
  • google-cloud-java version(s): 0.79.0-alpha

Steps to reproduce

  1. Use Guava
  2. Import google-cloud-logging-logback
  3. Run a build checker that ensures dependency convergence

Stacktrace

[INFO] --- maven-dependency-versions-check-plugin:2.0.2:check (default) @ mycorp-server ---
[INFO] Checking dependency versions
[ERROR] Found a problem with the direct dependency com.google.guava:guava of the current project
  Expected version is 26.0-jre
  Resolved version is 26.0-jre
  Version 26.0-android was expected by artifact: com.google.cloud:google-cloud-logging-logback
  Version 26.0-jre was expected by artifacts: com.mycorp.components:mycorp-jaxrs-client, com.mycorp.components:mycorp-spring

Metadata

Metadata

Assignees

Labels

type: questionRequest for information or clarification. Not an issue.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions