Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ensure generated samples directory is being copied over from googleapis-gen #8767

@alicejli

Description

@alicejli

Some modules do not have the generated samples directory copied over from googleapis-gen. For instance see java-container in googleapis-gen: https://github.com/googleapis/googleapis-gen/commit/73ec3348990fb308d3b600a0940ae852d47247ee, but the same PR in the monorepo doesn't contain the samples/snippets/generated directory: googleapis/java-container#848

This is because some modules are missing the correct copy/remove regexes in their .OwlBot.yaml files.

deep-remove-regex:

  • "/samples/snippets/generated"

deep-copy-regex:

  • source: "/google/cloud/${module_name}/(v.)/.-java/samples/snippets/generated"
    dest: "/owl-bot-staging/${module_name}/$1/samples/snippets/generated"

See https://github.com/google-cloud-java/blob/main/java-apigee-registry/.OwlBot.yaml as an example of a correct file.

The new client generation file should get updated as well: https://github.com/googleapis/google-cloud-java/blob/main/generation/new_client/templates/owlbot.yaml.monorepo.j2

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions