-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: add librarian state.yaml #14108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
.librarian/state.yaml
Outdated
@@ -0,0 +1,16 @@ | |||
image: gapic-generator-python:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be google-cloud-python-generator
?
I understand that this may not make a difference for our local testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 5f5038e
remove_regex: '' | ||
sourcePaths: | ||
- packages/google-cloud-language | ||
version: 2.17.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you file and link an issue here to remove this file once we're done with our local testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't be deleting state.yaml. The plan is to have an initial state.yaml when we onboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Librarian will be creating the state.yaml
file and maintaining it once we have configure
implemented. Ideally, state.yaml shouldn't have any manual edits.
We're only creating this file for the first milestone. Once we've got configure in place, Librarian should create and place the state.yaml
file in the /.librarian folder.
Why do we want an initial handwritten state.yaml (apart from the first milestone)?
remove_regex: '' | ||
sourcePaths: | ||
- packages/google-cloud-language | ||
version: 2.17.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Librarian will be creating the state.yaml
file and maintaining it once we have configure
implemented. Ideally, state.yaml shouldn't have any manual edits.
We're only creating this file for the first milestone. Once we've got configure in place, Librarian should create and place the state.yaml
file in the /.librarian folder.
Why do we want an initial handwritten state.yaml (apart from the first milestone)?
Fixes googleapis/librarian#867