Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: update CONTRIBUTING.md for users without branch permissions #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2025
Merged

docs: update CONTRIBUTING.md for users without branch permissions #3670

merged 1 commit into from
Feb 11, 2025

Conversation

PhongChuong
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes # b/388776589 ☕️

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Feb 11, 2025
whuffman36
whuffman36 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@whuffman36 whuffman36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhongChuong PhongChuong marked this pull request as ready for review February 11, 2025 18:40
@PhongChuong PhongChuong requested review from a team as code owners February 11, 2025 18:40
@PhongChuong PhongChuong merged commit 009b9a2 into main Feb 11, 2025
17 checks passed
@PhongChuong PhongChuong deleted the b388776589 branch February 11, 2025 18:41
@release-please release-please bot mentioned this pull request Feb 11, 2025
Merged
This was referenced Feb 18, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995 Neenu1995 is a code owner automatically assigned from googleapis/api-bigquery

1 more reviewer

@whuffman36 whuffman36 whuffman36 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhongChuong @whuffman36