This repository was archived by the owner on Feb 24, 2026. It is now read-only.
feat(bigquery): Integrate Otel Tracing in storage lib#2983
Merged
Conversation
shollyman
reviewed
May 28, 2025
| readRowsCallable = | ||
| settings | ||
| .getOpenTelemetryTracer() | ||
| .spanBuilder("com.google.cloud.bigquery.storage.v1.read.readRowsCallable") |
Contributor
There was a problem hiding this comment.
The behavior here is we'll get a single span that represents the lifetime of the server streaming rpc? Can/should we add an attribute implicating the stream ID requested from the ReadRowsRequest?
Contributor
Author
There was a problem hiding this comment.
Stream ID seems like a good field to capture. I could be mistaken, but it seems like the ReadRowsRequest is handled by generated code and in this context we don't have access to the stream ID (ie can't put it in the attributes). Do you know of a way we can get the stream ID in the ReadClient or its enhanced stub @Neenu1995 ?
Contributor
There was a problem hiding this comment.
The jdbc gets the StreamName from the readSession. I don't know if stream ID is accessible anywhere else.
shollyman
approved these changes
May 28, 2025
Neenu1995
approved these changes
May 29, 2025
lqiu96
pushed a commit
that referenced
this pull request
Jun 5, 2025
* feat(bigquery): Integrate Otel Tracing in storage lib * fix style * add sdk dependencies * Improve IT test coverage * fix IT test failures * Move otel init to specific test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds OpenTelemetry tracing support to the BigQueryReadClient and the BigQueryEnhancedReadStub. Tracing is toggled with a boolean flag and is enabled through the BigQueryReadSettings when creating the BigQueryReadClient.