diff --git a/.github/sync-repo-settings.yaml b/.github/sync-repo-settings.yaml
index 5539fb82c..19ecc2ed8 100644
--- a/.github/sync-repo-settings.yaml
+++ b/.github/sync-repo-settings.yaml
@@ -112,6 +112,23 @@ branchProtectionRules:
- OwlBot Post Processor
- 'Kokoro - Test: Java GraalVM Native Image'
- 'Kokoro - Test: Java 17 GraalVM Native Image'
+ - pattern: V3-experimental
+ isAdminEnforced: true
+ requiredApprovingReviewCount: 1
+ requiresCodeOwnerReviews: true
+ requiresStrictStatusChecks: false
+ requiredStatusCheckContexts:
+ - dependencies (17)
+ - lint
+ - clirr
+ - units (8)
+ - units (11)
+ - 'Kokoro - Test: Integration'
+ - cla/google
+ - OwlBot Post Processor
+ - 'Kokoro - Test: Java GraalVM Native Image'
+ - 'Kokoro - Test: Java 17 GraalVM Native Image'
+ - javadoc
- pattern: 2.15.x
isAdminEnforced: true
requiredApprovingReviewCount: 1
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a0b333bbe..a6953a424 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,18 @@
# Changelog
+## [2.17.6](https://github.com/googleapis/java-datastore/compare/v2.17.5...v2.17.6) (2023-11-30)
+
+
+### Bug Fixes
+
+* Remove deprecated `databaseId` field in DatastoreOptions ([#1237](https://github.com/googleapis/java-datastore/issues/1237)) ([05e25e5](https://github.com/googleapis/java-datastore/commit/05e25e5d31f72f9cdedbb5efa85c64b55ccbc405))
+
+
+### Dependencies
+
+* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.20.0 ([#1247](https://github.com/googleapis/java-datastore/issues/1247)) ([c4e3533](https://github.com/googleapis/java-datastore/commit/c4e3533fe357827cc25d0f029e5a83ced31db12a))
+* Update dependency org.junit.vintage:junit-vintage-engine to v5.10.1 ([#1230](https://github.com/googleapis/java-datastore/issues/1230)) ([05c7fc6](https://github.com/googleapis/java-datastore/commit/05c7fc69d52f5a9026a6529f638fe6164860e8f9))
+
## [2.17.5](https://github.com/googleapis/java-datastore/compare/v2.17.4...v2.17.5) (2023-11-02)
diff --git a/README.md b/README.md
index 0e7b9830b..31a90d7fb 100644
--- a/README.md
+++ b/README.md
@@ -19,7 +19,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file:
{@code - * CommitRequest.newBuilder() - * .setDatabaseId("my-database-id") - * .... - * .build(); - * }- */ - @BetaApi - @Deprecated - public Builder databaseId(String databaseId) { - this.databaseId = databaseId; - return this; - } - /** * Sets the host used to access Cloud Datastore. To connect to the Cloud Datastore Emulator, use * {@link #localHost} instead. @@ -203,23 +178,6 @@ public String getProjectId() { return projectId; } - /** - * This field is ignored and will be removed in a future release. Please set the database id on - * the request itself. For example: - * - *
{@code - * CommitRequest.newBuilder() - * .setDatabaseId("my-database-id") - * .... - * .build(); - * }- */ - @BetaApi - @Deprecated - public String getDatabaseId() { - return databaseId; - } - public String getProjectEndpoint() { return projectEndpoint; } diff --git a/datastore-v1-proto-client/src/test/java/com/google/datastore/v1/client/DatastoreClientTest.java b/datastore-v1-proto-client/src/test/java/com/google/datastore/v1/client/DatastoreClientTest.java index 3fd82ddca..16a6303bb 100644 --- a/datastore-v1-proto-client/src/test/java/com/google/datastore/v1/client/DatastoreClientTest.java +++ b/datastore-v1-proto-client/src/test/java/com/google/datastore/v1/client/DatastoreClientTest.java @@ -215,19 +215,6 @@ public void create_LocalHost() { .isEqualTo("http://localhost:8080/v1/projects/project-id"); } - @Test - // TODO: remove this test once deprecated `databaseId` is removed - public void setDatabaseId() { - DatastoreOptions options = - new DatastoreOptions.Builder() - .projectId(PROJECT_ID) - .databaseId("test-db") - .localHost("localhost:8080") - .build(); - assertThat(options.getProjectId()).isEqualTo(PROJECT_ID); - assertThat(options.getDatabaseId()).isEqualTo("test-db"); - } - @Test public void create_LocalHostIp() { Datastore datastore = diff --git a/google-cloud-datastore-bom/pom.xml b/google-cloud-datastore-bom/pom.xml index 71037fd1c..b224a6377 100644 --- a/google-cloud-datastore-bom/pom.xml +++ b/google-cloud-datastore-bom/pom.xml @@ -3,7 +3,7 @@
> { Q query; ListreadOptions; - private QueryAndReadOptions(Q query, List readOptions) { + private QueryConfig(Q query, List readOptions) { this.query = query; this.readOptions = readOptions; } - private QueryAndReadOptions(Q query) { + private QueryConfig(Q query) { this.query = query; this.readOptions = Collections.emptyList(); } @@ -165,13 +165,13 @@ public List getReadOptions() { return readOptions; } - public static > QueryAndReadOptionscreate(Q query) { - return new QueryAndReadOptions<>(query); + public static> QueryConfigcreate(Q query) { + return new QueryConfig<>(query); } - public static> QueryAndReadOptionscreate( + public static> QueryConfigcreate( Q query, ListreadOptions) { - return new QueryAndReadOptions<>(query, readOptions); + return new QueryConfig<>(query, readOptions); } } } diff --git a/google-cloud-datastore/src/main/java/com/google/cloud/datastore/execution/AggregationQueryExecutor.java b/google-cloud-datastore/src/main/java/com/google/cloud/datastore/execution/AggregationQueryExecutor.java index 14e425845..5a1fdd2c3 100644 --- a/google-cloud-datastore/src/main/java/com/google/cloud/datastore/execution/AggregationQueryExecutor.java +++ b/google-cloud-datastore/src/main/java/com/google/cloud/datastore/execution/AggregationQueryExecutor.java @@ -20,7 +20,7 @@ import com.google.cloud.datastore.AggregationResults; import com.google.cloud.datastore.DatastoreOptions; import com.google.cloud.datastore.ReadOption; -import com.google.cloud.datastore.ReadOption.QueryAndReadOptions; +import com.google.cloud.datastore.ReadOption.QueryConfig; import com.google.cloud.datastore.execution.request.AggregationQueryRequestProtoPreparer; import com.google.cloud.datastore.execution.response.AggregationQueryResponseTransformer; import com.google.cloud.datastore.spi.v1.DatastoreRpc; @@ -57,10 +57,10 @@ public AggregationResults execute(AggregationQuery query, ReadOption... readOpti private RunAggregationQueryRequest getRunAggregationQueryRequest( AggregationQuery query, ReadOption... readOptions) { - QueryAndReadOptions queryAndReadOptions = + QueryConfig queryConfig = readOptions == null - ? QueryAndReadOptions.create(query) - : QueryAndReadOptions.create(query, Arrays.asList(readOptions)); - return this.protoPreparer.prepare(queryAndReadOptions); + ? QueryConfig.create(query) + : QueryConfig.create(query, Arrays.asList(readOptions)); + return this.protoPreparer.prepare(queryConfig); } } diff --git a/google-cloud-datastore/src/main/java/com/google/cloud/datastore/execution/request/AggregationQueryRequestProtoPreparer.java b/google-cloud-datastore/src/main/java/com/google/cloud/datastore/execution/request/AggregationQueryRequestProtoPreparer.java index 5c4fb3e5f..475a47b58 100644 --- a/google-cloud-datastore/src/main/java/com/google/cloud/datastore/execution/request/AggregationQueryRequestProtoPreparer.java +++ b/google-cloud-datastore/src/main/java/com/google/cloud/datastore/execution/request/AggregationQueryRequestProtoPreparer.java @@ -22,7 +22,7 @@ import com.google.cloud.datastore.DatastoreOptions; import com.google.cloud.datastore.GqlQueryProtoPreparer; import com.google.cloud.datastore.ReadOption; -import com.google.cloud.datastore.ReadOption.QueryAndReadOptions; +import com.google.cloud.datastore.ReadOption.QueryConfig; import com.google.cloud.datastore.ReadOptionProtoPreparer; import com.google.cloud.datastore.StructuredQueryProtoPreparer; import com.google.cloud.datastore.aggregation.Aggregation; @@ -37,7 +37,7 @@ @InternalApi public class AggregationQueryRequestProtoPreparer - implements ProtoPreparer , RunAggregationQueryRequest> { + implements ProtoPreparer , RunAggregationQueryRequest> { private final DatastoreOptions datastoreOptions; private final StructuredQueryProtoPreparer structuredQueryProtoPreparer; @@ -52,10 +52,9 @@ public AggregationQueryRequestProtoPreparer(DatastoreOptions datastoreOptions) { } @Override - public RunAggregationQueryRequest prepare( - QueryAndReadOptions aggregationQueryAndReadOptions) { - AggregationQuery aggregationQuery = aggregationQueryAndReadOptions.getQuery(); - List readOptions = aggregationQueryAndReadOptions.getReadOptions(); + public RunAggregationQueryRequest prepare(QueryConfig queryConfig) { + AggregationQuery aggregationQuery = queryConfig.getQuery(); + List readOptions = queryConfig.getReadOptions(); PartitionId partitionId = getPartitionId(aggregationQuery); RunAggregationQueryRequest.Builder aggregationQueryRequestBuilder = RunAggregationQueryRequest.newBuilder() diff --git a/google-cloud-datastore/src/test/java/com/google/cloud/datastore/execution/request/AggregationQueryRequestProtoPreparerTest.java b/google-cloud-datastore/src/test/java/com/google/cloud/datastore/execution/request/AggregationQueryRequestProtoPreparerTest.java index 5fbb35b6e..0f22828d9 100644 --- a/google-cloud-datastore/src/test/java/com/google/cloud/datastore/execution/request/AggregationQueryRequestProtoPreparerTest.java +++ b/google-cloud-datastore/src/test/java/com/google/cloud/datastore/execution/request/AggregationQueryRequestProtoPreparerTest.java @@ -38,7 +38,7 @@ import com.google.cloud.datastore.GqlQuery; import com.google.cloud.datastore.Query; import com.google.cloud.datastore.ReadOption; -import com.google.cloud.datastore.ReadOption.QueryAndReadOptions; +import com.google.cloud.datastore.ReadOption.QueryConfig; import com.google.common.collect.ImmutableMap; import com.google.datastore.v1.RunAggregationQueryRequest; import java.util.HashMap; @@ -91,7 +91,7 @@ public class AggregationQueryRequestProtoPreparerTest { @Test public void shouldPrepareAggregationQueryRequestWithGivenStructuredQuery() { RunAggregationQueryRequest runAggregationQueryRequest = - protoPreparer.prepare(QueryAndReadOptions.create(AGGREGATION_OVER_STRUCTURED_QUERY)); + protoPreparer.prepare(QueryConfig.create(AGGREGATION_OVER_STRUCTURED_QUERY)); assertThat(runAggregationQueryRequest.getProjectId()).isEqualTo(PROJECT_ID); assertThat(runAggregationQueryRequest.getDatabaseId()).isEqualTo(DATABASE_ID); @@ -114,7 +114,7 @@ public void shouldPrepareAggregationQueryRequestWithGivenStructuredQuery() { @Test public void shouldPrepareAggregationQueryRequestWithGivenGqlQuery() { RunAggregationQueryRequest runAggregationQueryRequest = - protoPreparer.prepare(QueryAndReadOptions.create(AGGREGATION_OVER_GQL_QUERY)); + protoPreparer.prepare(QueryConfig.create(AGGREGATION_OVER_GQL_QUERY)); assertThat(runAggregationQueryRequest.getProjectId()).isEqualTo(PROJECT_ID); assertThat(runAggregationQueryRequest.getDatabaseId()).isEqualTo(DATABASE_ID); @@ -172,9 +172,9 @@ public void shouldPrepareAggregationQueryWithNamespaceFromDatastoreOptions() { Query.newAggregationQueryBuilder().over(COMPLETED_TASK_GQL_QUERY).build(); RunAggregationQueryRequest runAggregationQueryFromStructuredQuery = - protoPreparer.prepare(QueryAndReadOptions.create(structuredQueryWithoutNamespace)); + protoPreparer.prepare(QueryConfig.create(structuredQueryWithoutNamespace)); RunAggregationQueryRequest runAggregationQueryFromGqlQuery = - protoPreparer.prepare(QueryAndReadOptions.create(gqlQueryWithoutNamespace)); + protoPreparer.prepare(QueryConfig.create(gqlQueryWithoutNamespace)); assertThat(runAggregationQueryFromStructuredQuery.getPartitionId().getNamespaceId()) .isEqualTo(NAMESPACE); @@ -183,6 +183,6 @@ public void shouldPrepareAggregationQueryWithNamespaceFromDatastoreOptions() { } private RunAggregationQueryRequest prepareQuery(AggregationQuery query, ReadOption readOption) { - return protoPreparer.prepare(QueryAndReadOptions.create(query, singletonList(readOption))); + return protoPreparer.prepare(QueryConfig.create(query, singletonList(readOption))); } } diff --git a/grpc-google-cloud-datastore-admin-v1/pom.xml b/grpc-google-cloud-datastore-admin-v1/pom.xml index 8951daba1..c904b9827 100644 --- a/grpc-google-cloud-datastore-admin-v1/pom.xml +++ b/grpc-google-cloud-datastore-admin-v1/pom.xml @@ -4,13 +4,13 @@ 4.0.0 com.google.api.grpc grpc-google-cloud-datastore-admin-v1 -2.17.5 +2.17.6 grpc-google-cloud-datastore-admin-v1 GRPC library for google-cloud-datastore com.google.cloud google-cloud-datastore-parent -2.17.5 +2.17.6 diff --git a/pom.xml b/pom.xml index bcb632e53..676ba69b5 100644 --- a/pom.xml +++ b/pom.xml @@ -4,7 +4,7 @@ com.google.cloud google-cloud-datastore-parent pom -2.17.5 +2.17.6 Google Cloud Datastore Parent https://github.com/googleapis/java-datastore @@ -151,7 +151,7 @@ @@ -159,27 +159,27 @@ com.google.cloud google-cloud-shared-dependencies -3.19.0 +3.20.0 pom import com.google.api.grpc proto-google-cloud-datastore-admin-v1 -2.17.5 +2.17.6 com.google.api.grpc grpc-google-cloud-datastore-admin-v1 -2.17.5 +2.17.6 com.google.cloud google-cloud-datastore -2.17.5 +2.17.6 com.google.api.grpc proto-google-cloud-datastore-v1 -0.108.5 +0.108.6 com.google.cloud.datastore datastore-v1-proto-client -2.17.5 +2.17.6 com.google.api.grpc diff --git a/proto-google-cloud-datastore-admin-v1/pom.xml b/proto-google-cloud-datastore-admin-v1/pom.xml index 17c9cf990..45f206659 100644 --- a/proto-google-cloud-datastore-admin-v1/pom.xml +++ b/proto-google-cloud-datastore-admin-v1/pom.xml @@ -4,13 +4,13 @@4.0.0 com.google.api.grpc proto-google-cloud-datastore-admin-v1 -2.17.5 +2.17.6 proto-google-cloud-datastore-admin-v1 Proto library for google-cloud-datastore com.google.cloud google-cloud-datastore-parent -2.17.5 +2.17.6 diff --git a/proto-google-cloud-datastore-v1/pom.xml b/proto-google-cloud-datastore-v1/pom.xml index 65bae9fe6..7563d6f56 100644 --- a/proto-google-cloud-datastore-v1/pom.xml +++ b/proto-google-cloud-datastore-v1/pom.xml @@ -4,13 +4,13 @@ 4.0.0 com.google.api.grpc proto-google-cloud-datastore-v1 -0.108.5 +0.108.6 proto-google-cloud-datastore-v1 PROTO library for proto-google-cloud-datastore-v1 com.google.cloud google-cloud-datastore-parent -2.17.5 +2.17.6 diff --git a/samples/install-without-bom/pom.xml b/samples/install-without-bom/pom.xml index ee83c55b1..79297daf4 100644 --- a/samples/install-without-bom/pom.xml +++ b/samples/install-without-bom/pom.xml @@ -29,7 +29,7 @@ @@ -53,7 +53,7 @@ com.google.cloud google-cloud-datastore -2.17.4 +2.17.5 org.codehaus.mojo build-helper-maven-plugin -3.4.0 +3.5.0 add-snippets-source diff --git a/samples/native-image-sample/pom.xml b/samples/native-image-sample/pom.xml index 2e5ca1785..9ceacb5d5 100644 --- a/samples/native-image-sample/pom.xml +++ b/samples/native-image-sample/pom.xml @@ -28,7 +28,7 @@@@ -80,7 +80,7 @@ com.google.cloud libraries-bom -26.26.0 +26.27.0 pom import org.junit.vintage junit-vintage-engine -5.10.0 +5.10.1 test @@ -97,7 +97,7 @@ org.apache.maven.plugins maven-surefire-plugin -3.2.1 +3.2.2 **/IT* diff --git a/samples/snapshot/pom.xml b/samples/snapshot/pom.xml index d06377121..ed5fc68f4 100644 --- a/samples/snapshot/pom.xml +++ b/samples/snapshot/pom.xml @@ -28,7 +28,7 @@@@ -52,7 +52,7 @@ com.google.cloud google-cloud-datastore -2.17.5 +2.17.6 org.codehaus.mojo build-helper-maven-plugin -3.4.0 +3.5.0 add-snippets-source diff --git a/samples/snippets/pom.xml b/samples/snippets/pom.xml index 03b08298e..6cc5f1086 100644 --- a/samples/snippets/pom.xml +++ b/samples/snippets/pom.xml @@ -30,7 +30,7 @@diff --git a/versions.txt b/versions.txt index f8fa33ea0..e3de8713c 100644 --- a/versions.txt +++ b/versions.txt @@ -1,9 +1,9 @@ # Format: # module:released-version:current-version -google-cloud-datastore:2.17.5:2.17.5 -google-cloud-datastore-bom:2.17.5:2.17.5 -proto-google-cloud-datastore-v1:0.108.5:0.108.5 -datastore-v1-proto-client:2.17.5:2.17.5 -proto-google-cloud-datastore-admin-v1:2.17.5:2.17.5 -grpc-google-cloud-datastore-admin-v1:2.17.5:2.17.5 +google-cloud-datastore:2.17.6:2.17.6 +google-cloud-datastore-bom:2.17.6:2.17.6 +proto-google-cloud-datastore-v1:0.108.6:0.108.6 +datastore-v1-proto-client:2.17.6:2.17.6 +proto-google-cloud-datastore-admin-v1:2.17.6:2.17.6 +grpc-google-cloud-datastore-admin-v1:2.17.6:2.17.6 com.google.cloud libraries-bom -26.26.0 +26.27.0 pom import